Story/cite 185 - Managed authorities page should be filterable by import source #302
+129
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new attribute to the model for importedauthoritiessources
|
Can one of the admins verify this patch? |
jdamerow
requested changes
Oct 17, 2025
| @RequestMapping("/auth/authority/list/{source}") | ||
| public String getAuthoritiesForSource(Model model, Authentication authentication, | ||
| @PathVariable("source") String source, @RequestParam(defaultValue = "1", required = false, value = "page") String page) { | ||
| System.out.println(source); |
| model.addAttribute("total", authoritiesPage.getTotalElements()); | ||
| model.addAttribute("totalPages", authoritiesPage.getTotalPages() > 0 ? authoritiesPage.getTotalPages() : 1); | ||
| model.addAttribute("currentPage", page); | ||
| return "auth/authorities/list"; |
Member
There was a problem hiding this comment.
code should be cleaned up with intentional empty lines to organize blocks and intentional newlines for parameters of long method calls.
| IUser user = (IUser) authentication.getPrincipal(); | ||
| List<ICitationGroup> userGroups = citationManager.getGroups(user); | ||
| Page<IAuthorityEntry> authoritiesPage = authorityService.getAll(user, | ||
| userGroups.stream().map(group -> group.getGroupId()).collect(Collectors.toList()),pageInt, authorityPageSize); |
Member
There was a problem hiding this comment.
see my comment below. This could for example be formatted something like:
Page<IAuthorityEntry> authoritiesPage = authorityService.getAll(
user,
userGroups.stream().map(group -> group.getGroupId()).collect(Collectors.toList()),
pageInt,
authorityPageSize);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
Managed authorities page should be filterable by import source
... Put ticket description here and add link to ticket ...
Once we know where an authority entry came from, it should be possible to filter the entries on the “Manage Authority Entries” page by source (e.g. show all from Viaf).
https://diging.atlassian.net/browse/CITE-185
Are there any other pull requests that this one depends on?
diging/citesphere-model#48
Anything else the reviewer needs to know?
... describe here ...