You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
'something/:thing/:thing_other' with the following bindings ['::thing::', '::thing other::'] produces something/::thing::/::thing::_other rather than something/::thing::/::thing other::
This is caused by the str_replace replacing the :thing part of :thing_other as well, few fixes I can think of:
Requiring params to also have an ending :, instead of :guild_id it'd be :guild_id: (breaking change for users who specify their own endpoints manually instead of using the constants)
Dont replace :guild_id, instead replace :guild_id/ AND /:guild_id with the appropriate param, not breaking
Setting a priority to params to replace, in the example provided :thing_other would get higher priority and be replaced first. This would still allow weird replacements when you use $onlyMajorParameters but it wouldnt cause issues for the rate limiting buckets as it's consistently weird
Currently, there's no endpoints for Discord that would run into this issue. Low priority.
The text was updated successfully, but these errors were encountered:
We actually also have to replace the placeholder symbol, i just found a case where we have to deal with reactions endpoints and a custom emoji needs to be in format name:id, the colon in value will break the binding replacement placeholder
'something/:thing/:thing_other'
with the following bindings['::thing::', '::thing other::']
producessomething/::thing::/::thing::_other
rather thansomething/::thing::/::thing other::
This is caused by the
str_replace
replacing the:thing
part of:thing_other
as well, few fixes I can think of::
, instead of:guild_id
it'd be:guild_id:
(breaking change for users who specify their own endpoints manually instead of using the constants):guild_id
, instead replace:guild_id/
AND/:guild_id
with the appropriate param, not breaking:thing_other
would get higher priority and be replaced first. This would still allow weird replacements when you use$onlyMajorParameters
but it wouldnt cause issues for the rate limiting buckets as it's consistently weirdCurrently, there's no endpoints for Discord that would run into this issue. Low priority.
The text was updated successfully, but these errors were encountered: