Remove break loop condition in batcher (EspressoSystems#733)

Author: ImJeremyHe

arbnode/batch_poster.go

@@ -2081,7 +2081,6 @@ func (b *BatchPoster) MaybePostSequencerBatch(ctx context.Context) (bool, error)
 	}
 
 	var getNextMessage func() (*arbostypes.MessageWithMetadata, error)
-	var breakLoopWhenErrorOccurs bool
 
 	if b.espressoStreamer == nil {
 		getNextMessage = func() (*arbostypes.MessageWithMetadata, error) {
@@ -2091,7 +2090,6 @@ func (b *BatchPoster) MaybePostSequencerBatch(ctx context.Context) (bool, error)
 			}
 			return msg, nil
 		}
-		breakLoopWhenErrorOccurs = false
 	} else {
 		getNextMessage = func() (*arbostypes.MessageWithMetadata, error) {
 			espressoMsg := b.espressoStreamer.Next(ctx)
@@ -2100,7 +2098,6 @@ func (b *BatchPoster) MaybePostSequencerBatch(ctx context.Context) (bool, error)
 			}
 			return &espressoMsg.MessageWithMeta, nil
 		}
-		breakLoopWhenErrorOccurs = true
 	}
 
 	if b.building.firstDelayedMsg != nil {
@@ -2114,11 +2111,8 @@ func (b *BatchPoster) MaybePostSequencerBatch(ctx context.Context) (bool, error)
 	for b.building.msgCount < msgCount {
 		msg, err := getNextMessage()
 		if err != nil {
-			if breakLoopWhenErrorOccurs {
-				log.Error("error getting next message", "err", err, "pos", b.building.msgCount)
-				break
-			}
-			return false, err
+			log.Error("error getting next message", "err", err, "pos", b.building.msgCount)
+			break
 		}
 
 		if msg.Message.Header.BlockNumber < l1BoundMinBlockNumberWithBypass || msg.Message.Header.Timestamp < l1BoundMinTimestampWithBypass {