fix!: mark jobs as skipped instead of removing them #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a situation where a job is required for a PR merge to still pass if they are skipped as per the documentation here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks BREAKING CHANGE: a new job conditional will be required ``` if: matrix.target.skipped == true ``` Otherwise the job will still run. This allows GitHub to properly update the status of the job without actually having to run it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a situation where a job is required for a PR merge to still pass if they are skipped as per the documentation here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
BREAKING CHANGE: a new job conditional will be required
Otherwise the job will still run. This allows GitHub to properly update the status of the job without actually having to run it.
Draft Context
Unfortunately this doesn't work as is, but I have requested upstream the possibility of making the
matrixcontext available in anifblock:https://github.com/orgs/community/discussions/37883#discussioncomment-7052195