Skip to content

Commit 2c26dbb

Browse files
committed
fix: use BUMPY_GH_TOKEN for draft release operations
The draft release functions (createDraftRelease, updateReleaseBody, finalizeRelease, deleteRelease) were not using withReleaseToken, so GitHub release events were created with GITHUB_TOKEN which doesn't trigger downstream workflows like on-release.yaml.
1 parent 42fa0a1 commit 2c26dbb

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.bumpy/disable-staged-publishing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
'@varlock/bumpy': patch
33
---
44

5-
Disable npm staged publishing — feature is not yet ready for production use. Removes `npmStaged` config and the npm upgrade step from the release workflow.
5+
Disable npm staged publishing — feature is not yet ready for production use. Removes `npmStaged` config and the npm upgrade step from the release workflow. Also fix draft release functions (`createDraftRelease`, `updateReleaseBody`, `finalizeRelease`, `deleteRelease`) to use `BUMPY_GH_TOKEN` via `withReleaseToken` so that GitHub release events trigger downstream workflows.

packages/bumpy/src/core/github-release.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -291,22 +291,22 @@ export async function createDraftRelease(
291291
): Promise<void> {
292292
const args = ['gh', 'release', 'create', tag, '--title', title, '--notes', body, '--draft'];
293293
if (targetSha) args.push('--target', targetSha);
294-
await runArgsAsync(args, { cwd: rootDir });
294+
await withReleaseToken(() => runArgsAsync(args, { cwd: rootDir }));
295295
}
296296

297297
/** Update an existing GitHub release's body */
298298
export async function updateReleaseBody(tag: string, body: string, rootDir: string): Promise<void> {
299-
await runArgsAsync(['gh', 'release', 'edit', tag, '--notes', body], { cwd: rootDir });
299+
await withReleaseToken(() => runArgsAsync(['gh', 'release', 'edit', tag, '--notes', body], { cwd: rootDir }));
300300
}
301301

302302
/** Finalize a draft release (remove draft status) */
303303
export async function finalizeRelease(tag: string, rootDir: string): Promise<void> {
304-
await runArgsAsync(['gh', 'release', 'edit', tag, '--draft=false'], { cwd: rootDir });
304+
await withReleaseToken(() => runArgsAsync(['gh', 'release', 'edit', tag, '--draft=false'], { cwd: rootDir }));
305305
}
306306

307307
/** Delete a GitHub release */
308308
export async function deleteRelease(tag: string, rootDir: string): Promise<void> {
309-
await runArgsAsync(['gh', 'release', 'delete', tag, '--yes'], { cwd: rootDir });
309+
await withReleaseToken(() => runArgsAsync(['gh', 'release', 'delete', tag, '--yes'], { cwd: rootDir }));
310310
}
311311

312312
/** Find draft releases for a package (by name prefix) that are older than the current version */

0 commit comments

Comments
 (0)