Security hardening: eliminate shell injection vulnerabilities#3
Merged
Conversation
🐸 Bumpy Release Plan1 changeset(s) → 1 package(s) to release 🟢 Patch
This comment is maintained by bumpy. |
Replace shell string interpolation (execSync/exec) with execFile-based argument arrays throughout the codebase, preventing command injection via branch names, PR numbers, config values, package names, and registry URLs. - Add runArgs/runArgsAsync/tryRunArgs and sq() shell-quote helper to shell.ts - Migrate all git/gh commands to argument arrays in git.ts, ci.ts, check.ts, generate.ts, version.ts, changelog-github.ts, github-release.ts - Add input validation for branch names and PR numbers - Remove broken escapeShell function in favor of shell-free execution - Use sq() for template substitutions in custom publish commands - Convert buildPublishCommand/getPackCommand to return argument arrays - Restrict dynamic changelog formatter imports to project root - Use three-word random names to reduce changeset filename collisions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
theoephraim
force-pushed
the
fix/shell-injection-security
branch
from
78fb5c7 to
d28c9ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace shell string interpolation (execSync/exec) with execFile-based argument arrays throughout the codebase, preventing command injection via branch names, PR numbers, config values, package names, and registry URLs.