Skip to content

[BUG]: monkey-patching core objects is bad for performance #117

@wmertens

Description

@wmertens

varlock version

latest

Steps to reproduce

See https://github.com/dmno-dev/varlock/blob/main/packages/varlock/src/auto-load.ts#L5-L6 - Express changing the core objects actually gives a big performance hit, which is one of the reasons why fastify is faster, and I worry that these patches also do that.

What is expected?

Great DX, no runtime cost

What is actually happening?

Unknown, please benchmark to prove it's fine

System Info

Any additional comments?

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions