Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases v2 and v3 not compatible with go modules #184

Open
gnuletik opened this issue Jan 3, 2025 · 0 comments
Open

Releases v2 and v3 not compatible with go modules #184

gnuletik opened this issue Jan 3, 2025 · 0 comments

Comments

@gnuletik
Copy link

gnuletik commented Jan 3, 2025

Multiple tags have been created to create major releases (v2.0.0, v3.0.0):

But these releases cannot be installed because they don't respect go modules path.
This can be reproduced with the following commands:

$ cd /tmp && mkdir test-dnsimple && cd test-dnsimple && go mod init test
go: creating new go.mod: module test

$ go get github.com/dnsimple/[email protected]
go: github.com/dnsimple/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/dnsimple/dnsimple-go/v3")

We can also see on on pkg.go.dev that the new releases are not available.

See also the related documentation

So, the last version installable is v1.7.0.

Also, according to go convention, these releases doesn't contain breaking changes:

So, I think that the best solution would be to release the latest changes in a v1.8.0 to avoid bumping the major version.

WDYT ?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant