Skip to content

Commit f707a8a

Browse files
committed
chore
1 parent 3c92ccb commit f707a8a

File tree

2 files changed

+6
-24
lines changed

2 files changed

+6
-24
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,6 @@
22
name: Build and Push multi-arch Docker image
33

44
on:
5-
workflow_dispatch:
6-
inputs:
7-
version:
8-
description: tag name
9-
type: string
10-
required: true
115
release:
126
types:
137
- released
@@ -48,13 +42,11 @@ jobs:
4842
- name: Set release version
4943
if: ${{ matrix.use-buildx == true }}
5044
run: |
51-
echo "RELEASE_VERSION=$(echo '${{ github.event.inputs.version }}' | sed -e s/^v//)" >> $GITHUB_ENV
52-
# echo "RELEASE_VERSION=$(echo '${{ github.event.release.tag_name }}' | sed -e s/^v//)" >> $GITHUB_ENV
45+
echo "RELEASE_VERSION=$(echo '${{ github.event.release.tag_name }}' | sed -e s/^v//)" >> $GITHUB_ENV
5346
- name: Set release version
5447
if: ${{ matrix.use-buildx == false }}
5548
run: |
56-
echo "RELEASE_VERSION=$(echo '${{ github.event.inputs.version }}' | sed -e s/^v//)" | Out-File -FilePath $env:GITHUB_ENV -Append
57-
# echo "RELEASE_VERSION=$(echo '${{ github.event.release.tag_name }}' | sed -e s/^v//)" | Out-File -FilePath $env:GITHUB_ENV -Append
49+
echo "RELEASE_VERSION=$(echo '${{ github.event.release.tag_name }}' | sed -e s/^v//)" | Out-File -FilePath $env:GITHUB_ENV -Append
5850
- name: Print release version
5951
run: |
6052
echo ${{ env.RELEASE_VERSION }}
@@ -101,8 +93,7 @@ jobs:
10193
steps:
10294
- name: Set release version
10395
run: |
104-
echo "RELEASE_VERSION=$(echo '${{ github.event.inputs.version }}' | sed -e s/^v//)" >> $GITHUB_ENV
105-
# echo "RELEASE_VERSION=$(echo '${{ github.event.release.tag_name }}' | sed -e s/^v//)" >> $GITHUB_ENV
96+
echo "RELEASE_VERSION=$(echo '${{ github.event.release.tag_name }}' | sed -e s/^v//)" >> $GITHUB_ENV
10697
- name: Checkout
10798
uses: actions/checkout@v2
10899
- name: Login to DockerHub

README.md

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
# echo-server
22

3-
*TODO*: automatically create multiarch images for:
4-
5-
- Linux
6-
- Windows
7-
8-
A container's base image OS must match the host's OS: https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility?tabs=windows-server-1909%2Cwindows-10-1909
9-
10-
Otherwise we'll get error messages like this when trying to run an image with the wrong base image OS:
11-
12-
> The container operating system does not match the host operating system
13-
14-
See https://github.com/olljanat/multi-win-version-aspnet for an example of creating Windows multiarch images (source: https://github.com/moby/moby/issues/35247#issuecomment-436634221).
3+
A Docker image for multiple platforms (linux/amd64, linux/arm64/8, windows-ltsc2022)
4+
is available as `gesellix/echo-server:<version>`, with the `<version>` matching
5+
the Git tags and releases available at GitHub.

0 commit comments

Comments
 (0)