Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve_source_as_path always copies to temp #185

Open
J08nY opened this issue Mar 6, 2025 · 1 comment
Open

resolve_source_as_path always copies to temp #185

J08nY opened this issue Mar 6, 2025 · 1 comment

Comments

@J08nY
Copy link

J08nY commented Mar 6, 2025

As implemented in #79 the resource_source_as_path now always copies the source file into a (potentially temporary) workdir, even if the file is a local file and already has a path. This means that when one runs docling *.pdf with a lot of pdfs in the current working directory, docling spends a lot of time copying them over to a temporary directory. In one of my use cases the /var/tmp has per-user quotas and docling processing with a lot of PDFs has reached that quota and errored-out. I believe the default should be to not do a copy, or at least, there should be a way to request not doing a copy (via the CLI and also the library).

@J08nY
Copy link
Author

J08nY commented Mar 6, 2025

Also, as the Python docs say:

The user of mkdtemp() is responsible for deleting the temporary directory and its contents when done with it.

And I see no such calls in the code (or atexit registrations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant