Skip to content

feat: Add Table structure evaluations for TEDS #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

praveenmidde
Copy link
Contributor

As of now, the "evaluations" hold independent results of tables for TEDS only. Extend it to include the values of TEDS_struct evaluations as well.

  1. TableEvaluation class is extended to have another flag "is_structure_only" to distinguish between TEDS & TEDS_struct => The existing field "TEDS" will be the score as-is.
  2. Append the table_struct_evaluations as well into the result.

@praveenmidde praveenmidde self-assigned this May 8, 2025
@praveenmidde praveenmidde force-pushed the p_addStructOnlyResultsIntoEvaluations branch from e106bbe to bf29960 Compare May 8, 2025 05:16
@praveenmidde praveenmidde force-pushed the p_addStructOnlyResultsIntoEvaluations branch 2 times, most recently from 22c545d to 1d4579a Compare May 12, 2025 12:06
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Copy link

mergify bot commented Jun 5, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@praveenmidde praveenmidde changed the title Add Table structure evaluations for TEDS feat: Add Table structure evaluations for TEDS Jun 5, 2025
@praveenmidde praveenmidde force-pushed the p_addStructOnlyResultsIntoEvaluations branch from c06e87f to 4c2ed25 Compare June 5, 2025 05:22
Copy link
Contributor

@nikos-livathinos nikos-livathinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@divekarsc divekarsc requested a review from PeterStaar-IBM June 5, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants