Merge branch '4.4.x' into 5.0.x

* 4.4.x:
  Prepare the 4.4.0 release (#7233)
  Change MySQL bool declaration from TINYINT(1) to TINYINT (#7221)

Author: derrabus

.doctrine-project.json

@@ -11,17 +11,23 @@
             "slug": "latest",
             "upcoming": true
         },
+        {
+            "name": "4.5",
+            "branchName": "4.5.x",
+            "slug": "4.5",
+            "upcoming": true
+        },
         {
             "name": "4.4",
             "branchName": "4.4.x",
             "slug": "4.4",
-            "upcoming": true
+            "current": true
         },
         {
             "name": "4.3",
             "branchName": "4.3.x",
             "slug": "4.3",
-            "current": true
+            "maintained": false
         },
         {
             "name": "4.2",

README.md

@@ -1,9 +1,9 @@
 # Doctrine DBAL
 
-|                   [5.0-dev][5.0]                    |                   [4.4-dev][4.4]                    |                     [4.3][4.3]                      |                     [3.10][3.10]                      |
+|                   [5.0-dev][5.0]                    |                   [4.5-dev][4.5]                    |                     [4.4][4.4]                      |                     [3.10][3.10]                      |
 |:---------------------------------------------------:|:---------------------------------------------------:|:---------------------------------------------------:|:-----------------------------------------------------:|
-|      [![GitHub Actions][GA 5.0 image]][GA 5.0]      |      [![GitHub Actions][GA 4.4 image]][GA 4.4]      |      [![GitHub Actions][GA 4.3 image]][GA 4.3]      |      [![GitHub Actions][GA 3.10 image]][GA 3.10]      |
-| [![Code Coverage][Coverage 5.0 image]][CodeCov 5.0] | [![Code Coverage][Coverage 4.4 image]][CodeCov 4.4] | [![Code Coverage][Coverage 4.3 image]][CodeCov 4.3] | [![Code Coverage][Coverage 3.10 image]][CodeCov 3.10] |
+|      [![GitHub Actions][GA 5.0 image]][GA 5.0]      |      [![GitHub Actions][GA 4.5 image]][GA 4.5]      |      [![GitHub Actions][GA 4.4 image]][GA 4.4]      |      [![GitHub Actions][GA 3.10 image]][GA 3.10]      |
+| [![Code Coverage][Coverage 5.0 image]][CodeCov 5.0] | [![Code Coverage][Coverage 4.5 image]][CodeCov 4.5] | [![Code Coverage][Coverage 4.4 image]][CodeCov 4.4] | [![Code Coverage][Coverage 3.10 image]][CodeCov 3.10] |
 
 Powerful ***D***ata***B***ase ***A***bstraction ***L***ayer with many features for database schema introspection and schema management.
 
@@ -19,18 +19,18 @@ Powerful ***D***ata***B***ase ***A***bstraction ***L***ayer with many features f
   [GA 5.0]: https://github.com/doctrine/dbal/actions?query=workflow%3A%22Continuous+Integration%22+branch%3A5.0.x
   [GA 5.0 image]: https://github.com/doctrine/dbal/actions/workflows/continuous-integration.yml/badge.svg?branch=5.0.x
 
+  [Coverage 4.5 image]: https://codecov.io/gh/doctrine/dbal/branch/4.5.x/graph/badge.svg
+  [4.5]: https://github.com/doctrine/dbal/tree/4.5.x
+  [CodeCov 4.5]: https://codecov.io/gh/doctrine/dbal/branch/4.5.x
+  [GA 4.5]: https://github.com/doctrine/dbal/actions?query=workflow%3A%22Continuous+Integration%22+branch%3A4.5.x
+  [GA 4.5 image]: https://github.com/doctrine/dbal/actions/workflows/continuous-integration.yml/badge.svg?branch=4.5.x
+
   [Coverage 4.4 image]: https://codecov.io/gh/doctrine/dbal/branch/4.4.x/graph/badge.svg
   [4.4]: https://github.com/doctrine/dbal/tree/4.4.x
   [CodeCov 4.4]: https://codecov.io/gh/doctrine/dbal/branch/4.4.x
   [GA 4.4]: https://github.com/doctrine/dbal/actions?query=workflow%3A%22Continuous+Integration%22+branch%3A4.4.x
   [GA 4.4 image]: https://github.com/doctrine/dbal/actions/workflows/continuous-integration.yml/badge.svg?branch=4.4.x
 
-  [Coverage 4.3 image]: https://codecov.io/gh/doctrine/dbal/branch/4.3.x/graph/badge.svg
-  [4.3]: https://github.com/doctrine/dbal/tree/4.3.x
-  [CodeCov 4.3]: https://codecov.io/gh/doctrine/dbal/branch/4.3.x
-  [GA 4.3]: https://github.com/doctrine/dbal/actions?query=workflow%3A%22Continuous+Integration%22+branch%3A4.3.x
-  [GA 4.3 image]: https://github.com/doctrine/dbal/actions/workflows/continuous-integration.yml/badge.svg?branch=4.3.x
-
   [Coverage 3.10 image]: https://codecov.io/gh/doctrine/dbal/branch/3.10.x/graph/badge.svg
   [3.10]: https://github.com/doctrine/dbal/tree/3.10.x
   [CodeCov 3.10]: https://codecov.io/gh/doctrine/dbal/branch/3.10.x

src/Platforms/AbstractMySQLPlatform.php

@@ -180,7 +180,7 @@ public function getTimeTypeDeclarationSQL(array $column): string
      */
     public function getBooleanTypeDeclarationSQL(array $column): string
     {
-        return 'TINYINT(1)';
+        return 'TINYINT';
     }
 
     /**

tests/Functional/Schema/MySQLSchemaManagerTest.php

@@ -810,6 +810,29 @@ public function testSchemaDiffWithCustomColumnTypeWhileDatabaseTypeDiffers(): vo
         );
     }
 
+    public function testMigrateOldBoolean(): void
+    {
+        $this->connection->executeStatement('DROP TABLE IF EXISTS table_with_old_boolean');
+        $this->connection->executeStatement(
+            'CREATE TABLE table_with_old_boolean (val TINYINT(1) NOT NULL)',
+        );
+
+        $onlineTable = $this->schemaManager->introspectTableByUnquotedName('table_with_old_boolean');
+        $targetTable = Table::editor()
+            ->setUnquotedName('table_with_old_boolean')
+            ->setColumns(
+                Column::editor()
+                    ->setUnquotedName('val')
+                    ->setTypeName(Types::BOOLEAN)
+                    ->create(),
+            )
+            ->create();
+
+        $diff = $this->schemaManager->createComparator()->compareTables($onlineTable, $targetTable);
+
+        self::assertTrue($diff->isEmpty(), 'Tables should be identical.');
+    }
+
     public function getExpectedDefaultSchemaName(): ?string
     {
         return null;