🐛 Fix SQLite comment parsing when table and column have same name and both have a comment

Author: homersimpsons

src/Schema/SQLiteSchemaManager.php

@@ -390,7 +390,7 @@ private function parseTableCommentFromSQL(string $table, string $sql): ?string
     private function parseColumnCommentFromSQL(string $column, string $sql): string
     {
         $pattern = '{[\s(,]' . $this->buildIdentifierPattern($column)
-            . '(?:\([^)]*?\)|[^,(])*?,?((?:(?!\n))(?:\s*--[^\n]*\n?)+)}i';
+            . '\s(?:\([^)]*?\)|[^,(])*?,?((?:(?!\n))(?:\s+--[^\n]*\n?)+)}i';
 
         if (preg_match($pattern, $sql, $match) !== 1) {
             return '';

tests/Schema/SQLiteSchemaManagerTest.php

@@ -201,6 +201,14 @@ public static function getDataColumnComment(): iterable
                     PRIMARY KEY(id)
                 )',
             ],
+            'Column name equals table name and both have a comment' => [
+                'column comment',
+                'user',
+                'CREATE TABLE "user" --table comment
+                    (
+                        "user" INT --column comment
+                )'
+            ]
         ];
     }