Convert Request.js module and tests to TypeScript #143
Assignees
Labels
Comments
maier49
added a commit
to maier49/dstore
that referenced
this issue
Jul 27, 2015
Fixes dojo#143, Fixes dojo#138, Fixes dojo#137, Fixes dojo#136 * QueryResults has been converted to TypeScript * Filter has been converted to TypeScript * Store and tests/unit/Store have been converted. * Request and tests/unit/Request have been converted. All test cases that were previously passing are still passing, as well as the Request test cases. QueryResults needed to be modified to return an ES6 style promise, because of calls to super made by the promise returned from dojo-core/Request. This conversion in turn required many tests cases and some sources files to be updated, as they were relying on the fact that Dojo 1 style promises execute synchronously in some cases.
maier49
added a commit
to maier49/dstore
that referenced
this issue
Aug 7, 2015
Fixes dojo#143, Fixes dojo#138, Fixes dojo#137, Fixes dojo#136 * QueryResults has been converted to TypeScript * Filter has been converted to TypeScript * Store and tests/unit/Store have been converted. * Request and tests/unit/Request have been converted. All test cases that were previously passing are still passing, as well as the Request test cases. QueryResults needed to be modified to return an ES6 style promise, because of calls to super made by the promise returned from dojo-core/Request. This conversion in turn required many tests cases and some sources files to be updated, as they were relying on the fact that Dojo 1 style promises execute synchronously in some cases.
maier49
added a commit
to maier49/dstore
that referenced
this issue
Aug 21, 2015
Fixes dojo#143, Fixes dojo#138, Fixes dojo#137, Fixes dojo#136 * QueryResults has been converted to TypeScript * Filter has been converted to TypeScript * Store and tests/unit/Store have been converted. * Request and tests/unit/Request have been converted. All test cases that were previously passing are still passing, as well as the Request test cases. QueryResults needed to be modified to return an ES6 style promise, because of calls to super made by the promise returned from dojo-core/Request. This conversion in turn required many tests cases and some sources files to be updated, as they were relying on the fact that Dojo 1 style promises execute synchronously in some cases.
maier49
added a commit
to maier49/dstore
that referenced
this issue
Sep 4, 2015
Fixes dojo#143, Fixes dojo#138, Fixes dojo#137, Fixes dojo#136 * QueryResults has been converted to TypeScript * Filter has been converted to TypeScript * Store and tests/unit/Store have been converted. * Request and tests/unit/Request have been converted. All test cases that were previously passing are still passing, as well as the Request test cases. QueryResults needed to be modified to return an ES6 style promise, because of calls to super made by the promise returned from dojo-core/Request. This conversion in turn required many tests cases and some sources files to be updated, as they were relying on the fact that Dojo 1 style promises execute synchronously in some cases.
maier49
added a commit
to maier49/dstore
that referenced
this issue
Sep 11, 2015
Fixes dojo#143, Fixes dojo#138, Fixes dojo#137, Fixes dojo#136 * QueryResults has been converted to TypeScript * Filter has been converted to TypeScript * Store and tests/unit/Store have been converted. * Request and tests/unit/Request have been converted. All test cases that were previously passing are still passing, as well as the Request test cases. QueryResults needed to be modified to return an ES6 style promise, because of calls to super made by the promise returned from dojo-core/Request. This conversion in turn required many tests cases and some sources files to be updated, as they were relying on the fact that Dojo 1 style promises execute synchronously in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Convert
src/Request.jsto TypeScript assrc/Request.ts, andtests/unit/Request.jsastests/unit/Request.ts.This will also involve replacing usage of Dojo 1's
dojo/requestwith dojo-core's. This should ultimately enable all tests to pass again (right now they're failing due torequestProvidernot being configured).In order to run unit tests with the changes, any instances of
Requestwill need to be changed toRequest.defaultin other JS modules until we convert them as well.See #130 for general information on the conversion. If you have questions, comments, or thoughts for this module beyond the conversion itself, you can leave comments on this issue.
The text was updated successfully, but these errors were encountered: