Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Error disposing log descriptor" log level #8173

Open
1 task done
afscrome opened this issue Mar 19, 2025 · 0 comments
Open
1 task done

"Error disposing log descriptor" log level #8173

afscrome opened this issue Mar 19, 2025 · 0 comments

Comments

@afscrome
Copy link
Contributor

afscrome commented Mar 19, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

One of my apps got a random Error disposing log descriptor error. (Similar to #5995, although this time with a different error).

Whilst it would be nice to fix the underlying timeout error (although as I have no repro steps or additional logs, I'm not sure this is a particularly actionable), I wonder if this class of errors issues really be logged at Error level - sure it's a failure from the perspective of an engineer working on DCP. However the error doesn't seem to have any user impact, nor is there anything I can do as an aspire user to fix or mitigate it, so there seems little value in sharing it with the user - and particularly not as a bright red error that makes users think they've done something wrong.

fail: Aspire.Hosting.Dcp.dcp.start-apiserver.api-server.container-logstreamer.LogDescriptorSet[0]
      Error disposing log descriptor    {"ResourceName": {"name":"prometheusMetricsAdapter-bsqbtjgs"}, "ResourceUID": "946ef89e-b34f-4e9a-8ee6-cd558b90a2f4", "error": "context deadline exceeded\ncontext deadline exceeded"}

Expected Behavior

This error seems benign with no visible impact, so more like it should be at a warning level. Or possibly even Debug as I can't find any user impact from this error which would require me to know about this error.

Steps To Reproduce

Unfortunately no repro steps.

Exceptions (if any)

fail: Aspire.Hosting.Dcp.dcp.start-apiserver.api-server.container-logstreamer.LogDescriptorSet[0]
Error disposing log descriptor {"ResourceName": {"name":"prometheusMetricsAdapter-bsqbtjgs"}, "ResourceUID": "946ef89e-b34f-4e9a-8ee6-cd558b90a2f4", "error": "context deadline exceeded\ncontext deadline exceeded"}

.NET Version info

<PackageVersion Include="Aspire.Hosting" Version="9.1.0" />
<PackageVersion Include="Aspire.Hosting.AppHost" Version="9.1.0" />
<PackageVersion Include="Aspire.Hosting.Redis" Version="9.1.0" />
<PackageVersion Include="Aspire.Hosting.Testing" Version="9.1.0" />

Anything else?

This has some relation to #5995, although the exact error is different.

@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 19, 2025
@davidfowl davidfowl added area-orchestrator and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Mar 19, 2025
@karolz-ms karolz-ms added this to the Backlog milestone Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants