Fix construction of AsParameters with default constructor (#51582)

Author: captainsafia

src/Http/Http.Extensions/gen/StaticRouteHandlerModel/EndpointParameter.cs

@@ -171,7 +171,7 @@ Type is not INamedTypeSymbol namedTypeSymbol ||
             EndpointParameters = matchedProperties.Select(matchedParameter => new EndpointParameter(endpoint, matchedParameter.Property, matchedParameter.Parameter, wellKnownTypes));
             if (isDefaultConstructor == true)
             {
-                var parameterList = string.Join(", ", EndpointParameters.Select(p => $"{p.LookupName} = {p.EmitHandlerArgument()}"));
+                var parameterList = string.Join(", ", EndpointParameters.Select(p => $"{p.SymbolName} = {p.EmitHandlerArgument()}"));
                 AssigningCode = $"new {namedTypeSymbol.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat)} {{ {parameterList} }}";
             }
             else

src/Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTests.AsParameters.cs

@@ -74,14 +74,16 @@ static void TestAction([AsParameters] ParameterListFromQuery args)
         Assert.Equal(originalAnotherCustomQueryParam, httpContext.Items["anotherCustomInput"]);
     }
 
-    [Fact]
-    public async Task RequestDelegatePopulatesFromHeaderParameter_FromParameterList()
+    [Theory]
+    [InlineData("ParameterListFromHeader")]
+    [InlineData("ParameterListFromHeaderWithProperties")]
+    public async Task RequestDelegatePopulatesFromHeaderParameter_FromParameterList(string type)
     {
         const string customHeaderName = "X-Custom-Header";
         const int originalHeaderParam = 42;
 
-        var source = """
-static void TestAction([AsParameters] ParameterListFromHeader args)
+        var source = $$"""
+static void TestAction([AsParameters] {{type}} args)
 {
     args.HttpContext.Items.Add("input", args.Value);
 }

src/Http/Http.Extensions/test/RequestDelegateGenerator/SharedTypes.cs

@@ -698,6 +698,14 @@ public record ParameterListFromQuery(HttpContext HttpContext,
     [property: FromQuery(Name = "anotherCustomQuery")] int? AnotherCustomValue = null);
 public record ParameterListFromRoute(HttpContext HttpContext, int Value);
 public record ParameterListFromHeader(HttpContext HttpContext, [FromHeader(Name = "X-Custom-Header")] int Value);
+
+public record ParameterListFromHeaderWithProperties
+{
+    public HttpContext HttpContext { get; set; }
+    [FromHeader(Name = "X-Custom-Header")]
+    public int Value { get; set; }
+}
+
 public record ParametersListWithImplicitFromBody(HttpContext HttpContext, TodoStruct Todo);
 public record struct TodoStruct(int Id, string Name, bool IsComplete, TodoStatus Status) : ITodo;
 public record ParametersListWithExplicitFromBody(HttpContext HttpContext, [FromBody] Todo Todo);