Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xUnit support document of GenerateTestingPlatformEntryPoint #44090

Closed
filzrev opened this issue Dec 27, 2024 · 2 comments · Fixed by #44095
Closed

Remove xUnit support document of GenerateTestingPlatformEntryPoint #44090

filzrev opened this issue Dec 27, 2024 · 2 comments · Fixed by #44095
Assignees
Labels
in-pr This issue will be closed (fixed) by an active pull request.

Comments

@filzrev
Copy link

filzrev commented Dec 27, 2024

Type of issue

Code doesn't work

Description

Setting the GenerateTestingPlatformEntryPoint property to false disables the automatic generation of the program entry point in an MSTest, NUnit, or xUnit test project.

There is MSTest, NUnit, or xUnit test project. statement.
But GenerateTestingPlatformEntryPoint property is not supported by xUnit. And it's not works as described.

It is not be expected to be supported in the future.
So the reference to xUnit should be deleted from GenerateTestingPlatformEntryPoint property document .

See : xunit/xunit#3106

Page URL

https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#generatetestingplatformentrypoint

Content source URL

https://github.com/dotnet/docs/blob/main/docs/core/project-sdk/msbuild-props.md

Document Version Independent Id

6741b1de-38a4-fbb1-d79d-acc47d549a2d

Article author

@gewarren

Metadata

  • ID: cb4428fc-215c-78e1-5ff0-fe73f7a08260
  • Service: dotnet-fundamentals

Related Issues

@dotnetrepoman dotnetrepoman bot added the ⌚ Not Triaged Not triaged label Dec 27, 2024
@bradwilson
Copy link

To be clear, what @filzrev is referring to is xUnit.net v3, where all test projects are already stand-alone executables with entry points that we inject during build. As a result, we turn off GenerateTestingPlatformEntryPoint automatically in our NuGet package: https://github.com/xunit/xunit/blob/9853a4b92a41b0129c30a70cd040ea5213a016c6/src/xunit.v3.core/Package/build/xunit.v3.core.props#L9-L10

This mirrors behavior that we use to turn off entry point generation by VSTest: https://github.com/xunit/xunit/blob/9853a4b92a41b0129c30a70cd040ea5213a016c6/src/xunit.v3.core/Package/build/xunit.v3.core.props#L5-L6


xUnit.net versions prior to v3 do not support Microsoft.Testing.Platform at this time. There is an issue opened by @MarcoRossignoli to add support, with an implementation to be provided by the VSTest team: xunit/visualstudio.xunit#416

At this point in time, I have no insight as to whether this is being actively worked on and/or what the delivery date might be.

@gewarren gewarren self-assigned this Dec 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the in-pr This issue will be closed (fixed) by an active pull request. label Dec 27, 2024
@dotnetrepoman dotnetrepoman bot removed the ⌚ Not Triaged Not triaged label Dec 27, 2024
@MarcoRossignoli
Copy link
Member

cc: @Evangelink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-pr This issue will be closed (fixed) by an active pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants