Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making LibGpiodV1Driver and LibGpiodV2Driver public and removing factory #2382

Closed
krwq opened this issue Feb 13, 2025 · 0 comments · Fixed by #2386
Closed

Consider making LibGpiodV1Driver and LibGpiodV2Driver public and removing factory #2382

krwq opened this issue Feb 13, 2025 · 0 comments · Fixed by #2386
Assignees
@pgrawehr
Labels
enhancement New feature or request Priority:0 Work that we can't release without Status: In PR
Milestone
v4.0.0

Comments

@krwq
Copy link
Member

krwq commented Feb 13, 2025

Per @pgrawehr recommendation we should consider removing LibGpiodDriverFactory and version enum and instead making both V1 and V2 implementations public.

The default will be V1 with fallback to V2 (if V1 construction throws).

This will greatly simplify logic and remove ugly .so file probing.
@krwq krwq added the Priority:0 Work that we can't release without label Feb 13, 2025
@krwq krwq added the enhancement New feature or request label Feb 13, 2025
@krwq krwq added this to the v4.0.0 milestone Feb 13, 2025
@krwq krwq mentioned this issue Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgrawehr pgrawehr

Labels
enhancement New feature or request Priority:0 Work that we can't release without Status: In PR
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Make LibGpiodDriver V2 driver public pgrawehr/iot
2 participants
@krwq @pgrawehr