Skip to content

[Shell][Android] The truth is out there...but not on top tab search handlers #8716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidbritch opened this issue Jul 13, 2022 · 2 comments · May be fixed by #29545
Open

[Shell][Android] The truth is out there...but not on top tab search handlers #8716

davidbritch opened this issue Jul 13, 2022 · 2 comments · May be fixed by #29545
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout partner/syncfusion Issues / PR's with Syncfusion collaboration platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@davidbritch
Copy link
Contributor

davidbritch commented Jul 13, 2022

Description

I have this tab structure in my Shell app:

    <TabBar>
       <Tab Title="Domestic"
            Icon="paw.png">
           <ShellContent Title="Cats"
                         ContentTemplate="{DataTemplate views:CatsPage}" />
           <ShellContent Title="Dogs"
                         ContentTemplate="{DataTemplate views:DogsPage}" />
       </Tab>
      ...
    </TabBar>

So this gives us a Domestic bottom tab, and Cats and Dogs top tabs (within the Domestic tab).

CatsPage has a search handler which searches the cats data:

    <Shell.SearchHandler>
        <controls:AnimalSearchHandler Placeholder="Enter search term"
                                      ShowsResults="true"
                                      ItemTemplate="{StaticResource AnimalSearchTemplate}"
                                      Animals="{x:Static data:CatData.Cats}"
                                      SelectedItemNavigationTarget="{x:Type views:CatDetailPage}" />
   </Shell.SearchHandler>

It works fine:

Screenshot_1657724057

On DogsPage there's also a search handler that searches the dogs data:

    <Shell.SearchHandler>
        <controls:AnimalSearchHandler Placeholder="Enter search term"
                                      ShowsResults="true"
                                      ItemTemplate="{StaticResource AnimalSearchTemplate}"
                                      Animals="{x:Static data:DogData.Dogs}"
                                      SelectedItemNavigationTarget="{x:Type views:DogDetailPage}" />
    </Shell.SearchHandler>

However, using this search handler searches the cats data:

Screenshot_1657724070

This problem is only occurring for bottom tabs that also contain top tabs. For the elephants/monkeys/bears page the search handlers work as expected.

The problem might also occur on platforms other than Android, but right now in SR2 the app crashes on iOS/MacCatalyst, and on Windows the search handler doesn't template the results.

Repo: Xaminals.zip

Steps to Reproduce

  1. Run the attached sample on Android.
  2. Navigate to the Dogs top tab and search for dogs data. It searches cats data.

Version with bug

6.0.408

Last version that worked well

Unknown/Other

Affected platforms

Android

@davidbritch davidbritch added t/bug Something isn't working s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Jul 13, 2022
@jfversluis jfversluis added area-controls-shell Shell Navigation, Routes, Tabs, Flyout and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Jul 14, 2022
@rmarinho rmarinho added the s/verified Verified / Reproducible Issue ready for Engineering Triage label Jul 21, 2022
@mattleibow mattleibow added this to the Backlog milestone Feb 7, 2023
@ghost
Copy link

ghost commented Feb 7, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@samhouts samhouts removed the s/verified Verified / Reproducible Issue ready for Engineering Triage label Apr 5, 2023
@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels May 17, 2023
@Zhanglirong-Winnie
Copy link

Verified this issue with Visual Studio Enterprise 17.6.0 Preview 7.0. Repro on android platform with sample project.
Xaminals.zip
Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout partner/syncfusion Issues / PR's with Syncfusion collaboration platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
7 participants