Eliminate Verify.Xunit

Author: tmat

Directory.Packages.props

@@ -114,7 +114,6 @@
     <!-- Tests -->
     <PackageVersion Include="Microsoft.NET.Test.Sdk"                                                 Version="17.5.0-preview-20221003-04" />
     <PackageVersion Include="Moq"                                                                    Version="4.16.1" />
-    <PackageVersion Include="Verify.Xunit"                                                           Version="26.6.0" />
     <PackageVersion Include="xunit"                                                                  Version="2.9.0" />
     <PackageVersion Include="xunit.analyzers"                                                        Version="1.15.0"/>
     <PackageVersion Include="xunit.assert"                                                           Version="2.9.0" />

eng/imports/HostAgnostic.props

@@ -66,7 +66,6 @@
   <ItemGroup Condition="'$(IsUnitTestProject)' == 'true'">
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
     <PackageReference Include="Moq" />
-    <PackageReference Include="Verify.Xunit" />
     <PackageReference Include="xunit" />
     <PackageReference Include="xunit.analyzers" />
     <PackageReference Include="xunit.assert" />

tests/Microsoft.VisualStudio.ProjectSystem.Managed.UnitTests/Setup/PackageContentTests.NpmPackage.verified.txt

@@ -10,10 +10,32 @@ namespace Microsoft.VisualStudio.Setup;
 public sealed class PackageContentTests
 {
     [Fact]
-    public Task NpmPackage()
+    public void NpmPackage()
     {
-        IEnumerable<string> files = GetNpmPackageContents();
-        return Verifier.Verify(files);
+        var actual = GetNpmPackageContents();
+        var expected = new[]
+        {
+            @"cs\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"de\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"es\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"exports.json",
+            @"fr\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"it\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"ja\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"ko\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"Microsoft.CodeAnalysis.dll",
+            @"Microsoft.VisualStudio.ProjectSystem.Managed.dll",
+            @"Microsoft.VisualStudio.ProjectSystem.Managed.pdb",
+            @"package.json",
+            @"pl\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"pt-BR\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"ru\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"tr\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"zh-Hans\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+            @"zh-Hant\Microsoft.VisualStudio.ProjectSystem.Managed.resources.dll",
+        };
+
+        Assert.Equal(expected, actual);
     }
 
     private static IEnumerable<string> GetNpmPackageContents()
@@ -38,7 +60,8 @@ private static IEnumerable<string> GetNpmPackageContents()
             "npmsrc");
 
         return Directory.EnumerateFiles(packagesDirectory, "*", SearchOption.AllDirectories)
-            .Select(pullPath => Path.GetRelativePath(packagesDirectory, pullPath));
+            .Select(pullPath => Path.GetRelativePath(packagesDirectory, pullPath))
+            .OrderBy(path => path);
     }
 }