Update Xunit to 2.9.0

[tmat]

Configure Xunit to produce detaled console output, printing long-running test name every 20 seconds.

See https://dev.azure.com/dnceng-public/public/_build/results?buildId=1144401&view=logs&j=343adee7-d814-546f-dc3f-19ccb8aa9260&t=8dea7d69-d7ce-5872-c9d8-dd4fee7f95a7

Remove usage of Verify.Xunit.

[drewnoakes]

See also #9457

[drewnoakes]

Thanks for picking this up.

The conversion from Verify to Assert.Equals with two collections is a bit of a regression for cases where there are multiple differences. I believe xUnit's output doesn't provide a lot of detail here.

Can we add a helper method that detects when there's a difference and logs the full "expected" and "actual" items out, so that a test failure can be copy/pasted into a diff tool. Without something like this, you can end up going around in circles, especially if the failure only happen in CI.

[tmat]

Can we add a helper method that detects when there's a difference and logs the full "expected" and "actual" items out, so that a test failure can be copy/pasted into a diff tool. Without something like this, you can end up going around in circles, especially if the failure only happen in CI.

Let me copy a helper from Roslyn that does exactly that:

[drewnoakes]

Thanks!