Hard code ForceRuntimeCodeGeneration feature flag in all cases (#12007)

As discussed this morning, we can at least remove this from the UI and
ignore any attempts at configuration.

VS Code: dotnet/vscode-csharp#8398

Author: davidwengier

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/DefaultLanguageServerFeatureOptions.cs

@@ -35,8 +35,6 @@ internal class DefaultLanguageServerFeatureOptions : LanguageServerFeatureOption
 
     public override bool UseRazorCohostServer => false;
 
-    public override bool ForceRuntimeCodeGeneration => true;
-
     public override bool UseNewFormattingEngine => true;
 
     public override bool SupportsSoftSelectionInCompletion => true;

src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Hosting/ConfigurableLanguageServerFeatureOptions.cs

@@ -21,7 +21,6 @@ internal class ConfigurableLanguageServerFeatureOptions : LanguageServerFeatureO
     private readonly bool? _updateBuffersForClosedDocuments;
     private readonly bool? _includeProjectKeyInGeneratedFilePath;
     private readonly bool? _useRazorCohostServer;
-    private readonly bool? _forceRuntimeCodeGeneration;
     private readonly bool? _useNewFormattingEngine;
     private readonly bool? _doNotInitializeMiscFilesProjectFromWorkspace;
 
@@ -36,7 +35,6 @@ internal class ConfigurableLanguageServerFeatureOptions : LanguageServerFeatureO
     public override bool UpdateBuffersForClosedDocuments => _updateBuffersForClosedDocuments ?? _defaults.UpdateBuffersForClosedDocuments;
     public override bool IncludeProjectKeyInGeneratedFilePath => _includeProjectKeyInGeneratedFilePath ?? _defaults.IncludeProjectKeyInGeneratedFilePath;
     public override bool UseRazorCohostServer => _useRazorCohostServer ?? _defaults.UseRazorCohostServer;
-    public override bool ForceRuntimeCodeGeneration => _forceRuntimeCodeGeneration ?? _defaults.ForceRuntimeCodeGeneration;
     public override bool UseNewFormattingEngine => _useNewFormattingEngine ?? _defaults.UseNewFormattingEngine;
     public override bool SupportsSoftSelectionInCompletion => false;
     public override bool UseVsCodeCompletionTriggerCharacters => true;
@@ -67,7 +65,6 @@ public ConfigurableLanguageServerFeatureOptions(string[] args)
             TryProcessBoolOption(nameof(UpdateBuffersForClosedDocuments), ref _updateBuffersForClosedDocuments, option, args, i);
             TryProcessBoolOption(nameof(IncludeProjectKeyInGeneratedFilePath), ref _includeProjectKeyInGeneratedFilePath, option, args, i);
             TryProcessBoolOption(nameof(UseRazorCohostServer), ref _useRazorCohostServer, option, args, i);
-            TryProcessBoolOption(nameof(ForceRuntimeCodeGeneration), ref _forceRuntimeCodeGeneration, option, args, i);
             TryProcessBoolOption(nameof(UseNewFormattingEngine), ref _useNewFormattingEngine, option, args, i);
             TryProcessBoolOption(nameof(DoNotInitializeMiscFilesProjectFromWorkspace), ref _doNotInitializeMiscFilesProjectFromWorkspace, option, args, i);
         }

src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/LanguageServerFeatureOptions.cs

@@ -33,11 +33,6 @@ internal abstract class LanguageServerFeatureOptions
 
     public abstract bool UseRazorCohostServer { get; }
 
-    /// <summary>
-    /// When enabled, design time code will not be generated. All tooling, except formatting, will be using runtime code generation.
-    /// </summary>
-    public abstract bool ForceRuntimeCodeGeneration { get; }
-
     public abstract bool UseNewFormattingEngine { get; }
 
     /// <summary>
@@ -56,4 +51,12 @@ internal abstract class LanguageServerFeatureOptions
     /// all Razor files found under the workspace root path.
     /// </summary>
     public abstract bool DoNotInitializeMiscFilesProjectFromWorkspace { get; }
+
+    /// <summary>
+    /// When enabled, design time code will not be generated. All tooling, except formatting, will be using runtime code generation.
+    /// </summary>
+    /// <remarks>
+    /// This is now always <see langword="true" /> but cannot be removed entirely until the legacy editor is removed.
+    /// </remarks>
+    public bool ForceRuntimeCodeGeneration { get; } = true;
 }

src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/Initialization/RemoteLanguageServerFeatureOptions.cs

@@ -46,8 +46,6 @@ public void SetOptions(RemoteClientInitializationOptions options)
 
     public override bool UseRazorCohostServer => _options.UseRazorCohostServer;
 
-    public override bool ForceRuntimeCodeGeneration => true;
-
     public override bool UseNewFormattingEngine => true;
 
     public override bool SupportsSoftSelectionInCompletion => _options.SupportsSoftSelectionInCompletion;

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/VisualStudioLanguageServerFeatureOptions.cs

@@ -17,7 +17,6 @@ internal class VisualStudioLanguageServerFeatureOptions : LanguageServerFeatureO
     private readonly Lazy<bool> _includeProjectKeyInGeneratedFilePath;
     private readonly Lazy<bool> _usePreciseSemanticTokenRanges;
     private readonly Lazy<bool> _useRazorCohostServer;
-    private readonly Lazy<bool> _forceRuntimeCodeGeneration;
     private readonly Lazy<bool> _useNewFormattingEngine;
 
     [ImportingConstructor]
@@ -58,13 +57,6 @@ public VisualStudioLanguageServerFeatureOptions(ILspEditorFeatureDetector lspEdi
             return useRazorCohostServer;
         });
 
-        _forceRuntimeCodeGeneration = new Lazy<bool>(() =>
-        {
-            var featureFlags = (IVsFeatureFlags)Package.GetGlobalService(typeof(SVsFeatureFlags));
-            var forceRuntimeCodeGeneration = featureFlags.IsFeatureEnabled(WellKnownFeatureFlagNames.ForceRuntimeCodeGeneration, defaultValue: true);
-            return forceRuntimeCodeGeneration;
-        });
-
         _useNewFormattingEngine = new Lazy<bool>(() =>
         {
             var featureFlags = (IVsFeatureFlags)Package.GetGlobalService(typeof(SVsFeatureFlags));
@@ -98,9 +90,6 @@ public VisualStudioLanguageServerFeatureOptions(ILspEditorFeatureDetector lspEdi
 
     public override bool UseRazorCohostServer => _useRazorCohostServer.Value;
 
-    /// <inheritdoc />
-    public override bool ForceRuntimeCodeGeneration => _forceRuntimeCodeGeneration.Value;
-
     public override bool UseNewFormattingEngine => _useNewFormattingEngine.Value;
 
     // VS actually needs explicit commit characters so don't avoid them.

src/Razor/src/Microsoft.VisualStudio.LanguageServices.Razor/WellKnownFeatureFlagNames.cs

@@ -10,7 +10,6 @@ internal static class WellKnownFeatureFlagNames
     public const string UsePreciseSemanticTokenRanges = "Razor.LSP.UsePreciseSemanticTokenRanges";
     public const string UseRazorCohostServer = "Razor.LSP.UseRazorCohostServer";
     public const string DisableRazorLanguageServer = "Razor.LSP.DisableRazorLanguageServer";
-    public const string ForceRuntimeCodeGeneration = "Razor.LSP.ForceRuntimeCodeGeneration";
     public const string UseRoslynTokenizer = "Razor.LSP.UseRoslynTokenizer";
     public const string UseNewFormattingEngine = "Razor.LSP.UseNewFormattingEngine";
 }

src/Razor/src/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.Custom.pkgdef

@@ -63,12 +63,6 @@
 "Title"="Use Roslyn Cohost server for Razor (requires restart)"
 "PreviewPaneChannels"="*"
 
-[$RootKey$\FeatureFlags\Razor\LSP\ForceRuntimeCodeGeneration]
-"Description"="Enable combined design time/runtime code generation for Razor files"
-"Value"=dword:00000001
-"Title"="Force use of runtime code generation for Razor (requires restart)"
-"PreviewPaneChannels"="*"
-
 [$RootKey$\FeatureFlags\Razor\LSP\UseNewFormattingEngine]
 "Description"="Enables the new Razor formatting engine, which provides formatting results that more closely match C# formatting."
 "Value"=dword:00000001

src/Razor/src/Microsoft.VisualStudioCode.RazorExtension/Services/VSCodeLanguageServerFeatureOptions.cs

@@ -23,7 +23,6 @@ internal class VSCodeLanguageServerFeatureOptions(RazorClientServerManagerProvid
 {
     private bool _useRazorCohostServer = false;
     private bool _useNewFormattingEngine = true;
-    private bool _forceRuntimeCodeGeneration = false;
 
     private readonly RazorClientServerManagerProvider _razorClientServerManagerProvider = razorClientServerManagerProvider;
 
@@ -46,7 +45,6 @@ internal class VSCodeLanguageServerFeatureOptions(RazorClientServerManagerProvid
 
     // User configurable options
     public override bool UseRazorCohostServer => _useRazorCohostServer;
-    public override bool ForceRuntimeCodeGeneration => _forceRuntimeCodeGeneration;
     public override bool UseNewFormattingEngine => _useNewFormattingEngine;
 
     public int Order => WellKnownStartupOrder.LanguageServerFeatureOptions;
@@ -62,7 +60,6 @@ public async Task StartupAsync(VSInternalClientCapabilities clientCapabilities,
                 // Roslyn's typescript config handler will convert underscores to camelcase, ie 'razor.languageServer.cohostingEnabled'
                 new ConfigurationItem { Section = "razor.language_server.cohosting_enabled" },
                 new ConfigurationItem { Section = "razor.language_server.use_new_formatting_engine" },
-                new ConfigurationItem { Section = "razor.language_server.force_runtime_code_generation" },
             ]
         };
         var options = await razorClientLanguageServerManager.SendRequestAsync<ConfigurationParams, JsonArray>(
@@ -72,7 +69,6 @@ public async Task StartupAsync(VSInternalClientCapabilities clientCapabilities,
 
         _useRazorCohostServer = GetBooleanOptionValue(options[0], _useRazorCohostServer);
         _useNewFormattingEngine = GetBooleanOptionValue(options[1], _useNewFormattingEngine);
-        _forceRuntimeCodeGeneration = GetBooleanOptionValue(options[2], _forceRuntimeCodeGeneration);
 
         RazorCohostingOptions.UseRazorCohostServer = _useRazorCohostServer;
     }

src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common.Tooling/Workspaces/TestLanguageServerFeatureOptions.cs

@@ -7,7 +7,6 @@ namespace Microsoft.AspNetCore.Razor.Test.Common.Workspaces;
 
 internal class TestLanguageServerFeatureOptions(
     bool includeProjectKeyInGeneratedFilePath = false,
-    bool forceRuntimeCodeGeneration = false,
     bool updateBuffersForClosedDocuments = false,
     bool useNewFormattingEngine = false,
     bool supportsSoftSelectionInCompletion = true,
@@ -38,8 +37,6 @@ internal class TestLanguageServerFeatureOptions(
 
     public override bool UseRazorCohostServer => false;
 
-    public override bool ForceRuntimeCodeGeneration => forceRuntimeCodeGeneration;
-
     public override bool UseNewFormattingEngine => useNewFormattingEngine;
 
     public override bool SupportsSoftSelectionInCompletion => supportsSoftSelectionInCompletion;