move strings to resx

Author: rzikm

src/libraries/System.IO.Compression.ZStandard/src/Resources/Strings.resx

@@ -90,4 +90,13 @@
   <data name="ZStandardStream_ConcurrentRWOperation" xml:space="preserve">
     <value>Only one pending read/write operation is supported.</value>
   </data>
+  <data name="ZStandardDictionary_EmptyBuffer" xml:space="preserve">
+    <value>Buffer cannot be empty.</value>
+  </data>
+  <data name="ZStandardDictionary_CreateCompressionFailed" xml:space="preserve">
+    <value>Failed to create ZStandard compression dictionary.</value>
+  </data>
+  <data name="ZStandardDictionary_CreateDecompressionFailed" xml:space="preserve">
+    <value>Failed to create ZStandard decompression dictionary.</value>
+  </data>
 </root>

src/libraries/System.IO.Compression.ZStandard/src/System/IO/Compression/ZstandardDictionary.cs

@@ -28,7 +28,7 @@ private ZStandardDictionary(SafeZStdCDictHandle? compressionDict, SafeZStdDDictH
         public static ZStandardDictionary Create(ReadOnlyMemory<byte> buffer)
         {
             if (buffer.IsEmpty)
-                throw new ArgumentException("Buffer cannot be empty.", nameof(buffer));
+                throw new ArgumentException(SR.ZStandardDictionary_EmptyBuffer, nameof(buffer));
 
             byte[] dictionaryData = buffer.ToArray();
 
@@ -41,7 +41,7 @@ public static ZStandardDictionary Create(ReadOnlyMemory<byte> buffer)
                     // Create only decompression dictionary since no quality level is specified
                     SafeZStdDDictHandle decompressionDict = Interop.Zstd.ZSTD_createDDict(dictData, (nuint)dictionaryData.Length);
                     if (decompressionDict.IsInvalid)
-                        throw new InvalidOperationException("Failed to create ZStandard decompression dictionary.");
+                        throw new InvalidOperationException(SR.ZStandardDictionary_CreateDecompressionFailed);
 
                     return new ZStandardDictionary(null, decompressionDict, dictionaryData);
                 }
@@ -56,7 +56,7 @@ public static ZStandardDictionary Create(ReadOnlyMemory<byte> buffer)
         public static ZStandardDictionary Create(ReadOnlyMemory<byte> buffer, int quality)
         {
             if (buffer.IsEmpty)
-                throw new ArgumentException("Buffer cannot be empty.", nameof(buffer));
+                throw new ArgumentException(SR.ZStandardDictionary_EmptyBuffer, nameof(buffer));
 
             byte[] dictionaryData = buffer.ToArray();
 
@@ -69,14 +69,14 @@ public static ZStandardDictionary Create(ReadOnlyMemory<byte> buffer, int qualit
                     // Create both compression and decompression dictionaries
                     SafeZStdCDictHandle compressionDict = Interop.Zstd.ZSTD_createCDict(dictData, (nuint)dictionaryData.Length, quality);
                     if (compressionDict.IsInvalid)
-                        throw new InvalidOperationException("Failed to create ZStandard compression dictionary.");
+                        throw new InvalidOperationException(SR.ZStandardDictionary_CreateCompressionFailed);
                     compressionDict.Quality = quality;
 
                     SafeZStdDDictHandle decompressionDict = Interop.Zstd.ZSTD_createDDict(dictData, (nuint)dictionaryData.Length);
                     if (decompressionDict.IsInvalid)
                     {
                         compressionDict.Dispose();
-                        throw new InvalidOperationException("Failed to create ZStandard decompression dictionary.");
+                        throw new InvalidOperationException(SR.ZStandardDictionary_CreateDecompressionFailed);
                     }
 
                     return new ZStandardDictionary(compressionDict, decompressionDict, dictionaryData);