Address review suggestions.

Author: KlausLoeffelmann

.github/copilot-instructions.md

@@ -423,6 +423,16 @@ using Pen focusPen = new(focusColor) // Use 'using' with type name and omit type
 
 - **Don't XML-comment local functions**, as this is not supported. Instead, be more verbose in a comment if the local function's purpose is not immediately obvious.
 
+- **Use `<inheritdoc/>` for inherited members** to avoid duplication and ensure consistency in documentation.
+  ```csharp
+  /// <inheritdoc/>
+  public override void OnClick(EventArgs e)
+  {
+      base.OnClick(e);
+      // Additional logic here
+  }
+  ```
+
 ### 1.9 File Structure and Formatting
 
 - **Use file-scoped namespaces**

src/System.Windows.Forms/System/Windows/Forms/Controls/ToolStrips/ToolStripRenderer.cs

@@ -628,7 +628,7 @@ protected virtual void OnRenderArrow(ToolStripArrowRenderEventArgs e)
     /// <param name="e">The event arguments containing rendering information.</param>
     /// <param name="arrowColor">The color to use for the arrow.</param>
     /// <returns>The rendered arrow points.</returns>
-    private protected Point[] RenderArrowCore(
+    private protected void RenderArrowCore(
         ToolStripArrowRenderEventArgs e,
         Color arrowColor)
     {
@@ -661,38 +661,39 @@ private protected Point[] RenderArrowCore(
             ? s_offset4X - Offset2X
             : Offset2X;
 
-        Point[] arrow = e.Direction switch
+        // Use stackalloc for the 3 arrow points
+        Span<Point> arrow = stackalloc Point[3];
+
+        // Fill the points based on arrow direction
+        switch (e.Direction)
         {
-            ArrowDirection.Up =>
-            [
-                new(middle.X - Offset2X, middle.Y + 1),
-                new(middle.X + Offset2X + 1, middle.Y + 1),
-                new(middle.X, middle.Y - Offset2Y)
-            ],
-            ArrowDirection.Left =>
-            [
-                new(middle.X + Offset2X, middle.Y - s_offset4Y),
-                new(middle.X + Offset2X, middle.Y + s_offset4Y),
-                new(middle.X - horizontalOffset, middle.Y)
-            ],
-            ArrowDirection.Right =>
-            [
-                new(middle.X - Offset2X, middle.Y - s_offset4Y),
-                new(middle.X - Offset2X, middle.Y + s_offset4Y),
-                new(middle.X + horizontalOffset, middle.Y)
-            ],
-            _ =>
-            [
-                new(middle.X - Offset2X, middle.Y - 1),
-                new(middle.X + Offset2X + 1, middle.Y - 1),
-                new(middle.X, middle.Y + Offset2Y)
-            ],
-        };
+            case ArrowDirection.Up:
+                arrow[0] = new(middle.X - Offset2X, middle.Y + 1);
+                arrow[1] = new(middle.X + Offset2X + 1, middle.Y + 1);
+                arrow[2] = new(middle.X, middle.Y - Offset2Y);
+                break;
+
+            case ArrowDirection.Left:
+                arrow[0] = new(middle.X + Offset2X, middle.Y - s_offset4Y);
+                arrow[1] = new(middle.X + Offset2X, middle.Y + s_offset4Y);
+                arrow[2] = new(middle.X - horizontalOffset, middle.Y);
+                break;
+
+            case ArrowDirection.Right:
+                arrow[0] = new(middle.X - Offset2X, middle.Y - s_offset4Y);
+                arrow[1] = new(middle.X - Offset2X, middle.Y + s_offset4Y);
+                arrow[2] = new(middle.X + horizontalOffset, middle.Y);
+                break;
+
+            default: // Down
+                arrow[0] = new(middle.X - Offset2X, middle.Y - 1);
+                arrow[1] = new(middle.X + Offset2X + 1, middle.Y - 1);
+                arrow[2] = new(middle.X, middle.Y + Offset2Y);
+                break;
+        }
 
         using var brush = arrowColor.GetCachedSolidBrushScope();
         g.FillPolygon(brush, arrow);
-
-        return arrow;
     }
 
     /// <summary>
@@ -1029,17 +1030,17 @@ protected virtual void OnRenderStatusStripSizingGrip(ToolStripRenderEventArgs e)
         }
 
         OnRenderStatusStripSizingGrip(
-            eArgs: e,
+            e: e,
             highLightBrush: SystemBrushes.ButtonHighlight,
             shadowBrush: SystemBrushes.GrayText);
     }
 
     private protected static void OnRenderStatusStripSizingGrip(
-        ToolStripRenderEventArgs eArgs,
+        ToolStripRenderEventArgs e,
         Brush highLightBrush,
         Brush shadowBrush)
     {
-        if (eArgs.ToolStrip is not StatusStrip statusStrip)
+        if (e.ToolStrip is not StatusStrip statusStrip)
         {
             return;
         }
@@ -1051,7 +1052,7 @@ private protected static void OnRenderStatusStripSizingGrip(
             return;
         }
 
-        Graphics g = eArgs.Graphics;
+        Graphics g = e.Graphics;
         ReadOnlySpan<Rectangle> baseRectangles = s_baseSizeGripRectangles;
 
         // Reference height for sizing grips at 96 DPI (standard sizing)

src/System.Windows.Forms/System/Windows/Forms/Controls/ToolStrips/ToolStripSystemDarkModeRenderer.cs

@@ -114,14 +114,15 @@ protected override void OnRenderToolStripBackground(ToolStripRenderEventArgs e)
         ArgumentNullException.ThrowIfNull(e);
 
         ToolStrip toolStrip = e.ToolStrip;
-        Graphics g = e.Graphics;
         Rectangle bounds = e.AffectedBounds;
 
         if (!ShouldPaintBackground(toolStrip))
         {
             return;
         }
 
+        Graphics g = e.Graphics;
+
         if (toolStrip is StatusStrip)
         {
             RenderStatusStripBackground(e);
@@ -152,11 +153,10 @@ protected override void OnRenderToolStripBackground(ToolStripRenderEventArgs e)
     /// <param name="e">A ToolStripRenderEventArgs that contains the event data.</param>
     internal static void RenderStatusStripBackground(ToolStripRenderEventArgs e)
     {
-        Graphics g = e.Graphics;
         Rectangle bounds = e.AffectedBounds;
 
         // Dark mode StatusStrip background
-        FillBackground(g, bounds, GetDarkModeColor(SystemColors.Control));
+        FillBackground(e.Graphics, bounds, GetDarkModeColor(SystemColors.Control));
     }
 
     /// <summary>
@@ -168,18 +168,18 @@ protected override void OnRenderToolStripBorder(ToolStripRenderEventArgs e)
         ArgumentNullException.ThrowIfNull(e);
 
         ToolStrip toolStrip = e.ToolStrip;
-        Graphics g = e.Graphics;
-        Rectangle bounds = e.ToolStrip.ClientRectangle;
-
-        using var borderPen = GetDarkModePen(SystemColors.ControlDark);
 
         if (toolStrip is StatusStrip)
         {
             RenderStatusStripBorder(e);
-
             return;
         }
 
+        Graphics g = e.Graphics;
+        Rectangle bounds = e.ToolStrip.ClientRectangle;
+
+        using var borderPen = GetDarkModePen(SystemColors.ControlDark);
+
         if (toolStrip is ToolStripDropDown toolStripDropDown)
         {
             if (toolStripDropDown.DropShadowEnabled)
@@ -648,7 +648,7 @@ protected override void OnRenderStatusStripSizingGrip(ToolStripRenderEventArgs e
         using var shadowBrush = GetDarkModeBrush(SystemColors.ButtonShadow);
 
         OnRenderStatusStripSizingGrip(
-            eArgs: e,
+            e: e,
             highLightBrush: highLightBrush,
             shadowBrush: shadowBrush);
     }

src/System.Windows.Forms/System/Windows/Forms/Controls/ToolStrips/ToolStripSystemRenderer.cs

@@ -251,7 +251,7 @@ protected override void OnRenderToolStripBackground(ToolStripRenderEventArgs e)
             }
             else if (DisplayInformation.LowResolution)
             {
-                FillBackground(g, bounds, (toolStrip is ToolStripDropDown)
+                FillBackground(g, bounds, toolStrip is ToolStripDropDown
                      ? SystemColors.ControlLight
                      : e.BackColor);
             }