Merge branch 'main' of github.com:dotnet/winforms into Add_Code_Coverage_For_Buttons

Author: Ricardo Bossan (BEYONDSOFT CONSULTING INC) (from Dev Box)

.editorconfig

@@ -26,10 +26,10 @@ insert_final_newline = true
 trim_trailing_whitespace = true
 
 # avoid this. unless absolutely necessary
-dotnet_style_qualification_for_field = false:suggestion
-dotnet_style_qualification_for_property = false:suggestion
-dotnet_style_qualification_for_method = false:suggestion
-dotnet_style_qualification_for_event = false:suggestion
+dotnet_style_qualification_for_field = false:error
+dotnet_style_qualification_for_property = false:error
+dotnet_style_qualification_for_method = false:error
+dotnet_style_qualification_for_event = false:error
 # use language keywords instead of BCL types
 dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
 dotnet_style_predefined_type_for_member_access = true:suggestion
@@ -92,9 +92,45 @@ dotnet_style_allow_multiple_blank_lines_experimental = true:silent
 dotnet_style_allow_statement_immediately_after_block_experimental = true:silent
 dotnet_style_prefer_collection_expression = true:suggestion
 
+# IDE0040: Add accessibility modifiers
+dotnet_diagnostic.IDE0040.severity = error
+
 # C# files
+
 [*.cs]
 
+# These two conflict with our usage of CsWin32
+
+# SYSLIB1054: Use 'LibraryImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
+dotnet_diagnostic.SYSLIB1054.severity = none
+
+# SYSLIB1096: Convert to 'GeneratedComInterface'
+dotnet_diagnostic.SYSLIB1096.severity = none
+
+# IDE1006: Naming Styles
+dotnet_diagnostic.IDE1006.severity = error
+
+# CA1725: Parameter names should match base declaration
+dotnet_diagnostic.CA1725.severity = error
+
+# DOC100: Place text in paragraphs
+dotnet_diagnostic.DOC100.severity = error
+
+# CA1859: Use concrete types when possible for improved performance
+dotnet_diagnostic.CA1859.severity = error
+
+# IDE0002: Simplify Member Access
+dotnet_diagnostic.IDE0002.severity = error
+
+# IDE0003: Remove qualification
+dotnet_diagnostic.IDE0003.severity = error
+
+# IDE0079: Remove unnecessary suppression
+dotnet_diagnostic.IDE0079.severity = error
+
+# IDE0044: Add readonly modifier
+dotnet_diagnostic.IDE0044.severity = warning
+
 # .NET diagnostic
 dotnet_diagnostic.RS0041.severity = none
 dotnet_diagnostic.IDE0005.severity = error
@@ -182,9 +218,6 @@ csharp_style_deconstructed_variable_declaration = true:suggestion
 
 # Visual Basic files
 
-# SYSLIB1054: Use 'LibraryImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
-dotnet_diagnostic.SYSLIB1054.severity = none
-
 [*.vb]
 # Modifier preferences
 visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public,Friend,NotOverridable,Overridable,MustOverride,Overloads,Overrides,MustInherit,NotInheritable,Static,Shared,Shadows,ReadOnly,WriteOnly,Dim,Const,WithEvents,Widening,Narrowing,Custom,Async:suggestion
@@ -222,3 +255,16 @@ end_of_line = lf
 
 [*.{cmd,bat}]
 end_of_line = crlf
+
+# Test specific
+[**/tests/**/*.cs]
+
+# CA1861: Avoid constant arrays as arguments - expected to be inline for test readability (4000 hits)
+dotnet_diagnostic.CA1861.severity = silent
+
+# This should be fixed https://github.com/dotnet/winforms/issues/11041
+# xUnit1042: The member referenced by the MemberData attribute returns untyped data rows
+dotnet_diagnostic.xUnit1042.severity = none
+
+# CA1859: Use concrete types when possible for improved performance
+dotnet_diagnostic.CA1859.severity = none

.gitignore

@@ -29,8 +29,10 @@ bld/
 [Oo]bj/
 [Ll]og/
 
-# Visual Studio 2015/2017 cache/options directory
+# Visual Studio cache/options directory
 .vs/
+.vscode/
+
 # Uncomment if you have tasks that create the project's static files in wwwroot
 #wwwroot/
 

azure-pipelines-PR.yml

@@ -0,0 +1,111 @@
+# Parameters ARE available in template expressions, and parameters can have default values,
+# so they can be used to control yaml flow.
+
+# trigger ci builds for completed checkins into main and any release branches
+trigger:
+  branches:
+    include:
+      - main
+      - release/*
+      - internal/release/*
+      - internal/experimental/*
+  paths:
+    include:
+      - '*'
+    exclude:
+      - .github/*
+      - docs/*
+      - CODE-OF-CONDUCT.md
+      - CONTRIBUTING.md
+      - LICENSE.TXT
+      - PATENTS.TXT
+      - README.md
+      - SECURITY.md
+      - THIRD-PARTY-NOTICES.TXT
+
+# trigger ci builds on pull requests into main and any release branches
+pr:
+  autoCancel: true
+  branches:
+    include:
+      - main
+      - vnext
+      - release/*
+      - internal/release/*
+      - internal/experimental/*
+      - feature/win32
+      - feature/9.0
+  paths:
+    include:
+      - '*'
+    exclude:
+      - .github/*
+      - docs/*
+      - CODE-OF-CONDUCT.md
+      - CONTRIBUTING.md
+      - LICENSE.TXT
+      - PATENTS.TXT
+      - README.md
+      - SECURITY.md
+      - THIRD-PARTY-NOTICES.TXT
+
+variables:
+  - name: TeamName
+    value: DotNetCore
+  # clean the local repo on the build agents
+  - name: Build.Repository.Clean
+    value: true
+  - ${{ if or(startswith(variables['Build.SourceBranch'], 'refs/heads/release/'), startswith(variables['Build.SourceBranch'], 'refs/heads/internal/release/'), eq(variables['Build.Reason'], 'Manual')) }}:
+    - name: PostBuildSign
+      value: false
+  - ${{ else }}:
+    - name: PostBuildSign
+      value: true
+  - name: EnableLoc
+    value: ${{ contains(variables['Build.SourceBranch'], 'main') }}
+  - name: NativeToolsOnMachine
+    value: true
+
+  # used for post-build phases, no value for non-internal build
+  - name: _InternalRuntimeDownloadArgs
+    value: ''
+
+  # Produce test-signed build for PR and Public builds
+  # needed for darc (dependency flow) publishing
+  - name: _PublishArgs
+    value: ''
+  - name: _OfficialBuildIdArgs
+    value: ''
+  # needed for signing
+  - name: _SignType
+    value: test
+  - name: _SignArgs
+    value: ''
+  - name: _Sign
+    value: false
+
+stages:
+
+- stage: Build
+  jobs:
+
+  # Windows x64
+  - template: /eng/pipelines/build-PR.yml
+    parameters:
+      name: Windows_x64
+      targetArchitecture: x64
+      skipTests: $(SkipTests)
+
+  # Windows x86
+  - template: /eng/pipelines/build-PR.yml
+    parameters:
+      name: Windows_x86
+      targetArchitecture: x86
+      skipTests: $(SkipTests)
+
+  # Windows arm64
+  - template: /eng/pipelines/build-PR.yml
+    parameters:
+      name: Windows_arm64
+      targetArchitecture: arm64
+      skipTests: $(SkipTests)