Update test "ConvertFrom_ShouldConvertKeys_Localization" to use the SR resource name to retrieve the localized string (#13192)

* Update test "ConvertFrom_ShouldConvertKeys_Localization" to use the SR resource name to retrieve the localized string

* Restore SR.Culture to its original value at the end of the test

* Add test file KeysConverterTests.LocalizationTests

Author: LeafShi1

src/test/unit/System.Windows.Forms/System/Windows/Forms/KeysConverterTests.LocalizationTests.cs

@@ -0,0 +1,76 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System.Globalization;
+
+namespace System.Windows.Forms;
+
+public partial class KeysConverterTests
+{
+    // This test modifies global culture settings (Thread.CurrentUICulture and SR.Culture).
+    // As a result, it must run sequentially to avoid conflicts with other tests that may
+    // rely on or alter these settings. Running it in a sequential collection ensures consistent results.
+    [Collection("Sequential")]
+    public class LocalizationTests
+    {
+        [Theory]
+        [InlineData("fr-FR", "toStringNone", Keys.None)]
+        [InlineData("zh-CN", "toStringNone", Keys.None)]
+        [InlineData("nb-NO", "toStringNone", Keys.None)]
+        [InlineData("de-DE", "toStringEnd", Keys.End)]
+        public void ConvertFrom_ShouldConvertKeys_Localization(string cultureName, string resourceKey, Keys expectedKey)
+        {
+            // Record original culture.
+            CultureInfo originalUICulture = Thread.CurrentThread.CurrentUICulture;
+            CultureInfo originalSRCulture = SR.Culture;
+
+            CultureInfo targetCulture = CultureInfo.GetCultureInfo(cultureName);
+
+            try
+            {
+                // Use the SR resource key to retrieve the localized string corresponding to SR.Culture.
+                SR.Culture = targetCulture;
+                string localizedString = SR.GetResourceString(resourceKey);
+
+                KeysConverter converter = new();
+                var resultFromSpecificCulture = (Keys?)converter.ConvertFrom(context: null, targetCulture, localizedString);
+
+                Assert.Equal(expectedKey, resultFromSpecificCulture);
+
+                Thread.CurrentThread.CurrentUICulture = targetCulture;
+
+                // When the culture is empty, the 'localizedString' is converted
+                // to the corresponding key value based on CurrentUICulture.
+                var resultFromUICulture = (Keys?)converter.ConvertFrom(context: null, culture: null, localizedString);
+                Assert.Equal(expectedKey, resultFromUICulture);
+            }
+            finally
+            {
+                Thread.CurrentThread.CurrentUICulture = originalUICulture;
+                SR.Culture = originalSRCulture;
+            }
+        }
+
+        [Theory]
+        [InlineData("fr-FR", Keys.None, "toStringNone")]
+        [InlineData("de-DE", Keys.End, "toStringEnd")]
+        public void ConvertToString_ShouldConvertKeys_Localization(string cultureName, Keys key, string resourceKey)
+        {
+            CultureInfo originalSRCulture = SR.Culture;
+            try
+            {
+                CultureInfo targetCulture = CultureInfo.GetCultureInfo(cultureName);
+
+                KeysConverter converter = new();
+                string? result = converter.ConvertToString(null, targetCulture, key);
+
+                SR.Culture = targetCulture;
+                Assert.Equal(SR.GetResourceString(resourceKey), result);
+            }
+            finally
+            {
+                SR.Culture = originalSRCulture;
+            }
+        }
+    }
+}

src/test/unit/System.Windows.Forms/System/Windows/Forms/KeysConverterTests.cs

@@ -8,7 +8,7 @@
 
 namespace System.Windows.Forms.Tests;
 
-public class KeysConverterTests
+public partial class KeysConverterTests
 {
     [Theory]
     [UseDefaultXunitCulture]
@@ -25,36 +25,6 @@ public void ConvertFrom_ShouldConvertKeys(string input, Keys keys)
         Assert.Equal(keys, result);
     }
 
-    [Theory]
-    [InlineData("fr-FR", "(aucune)", Keys.None)]
-    [InlineData("nb-NO", "None", Keys.None)]
-    [InlineData("de-DE", "Ende", Keys.End)]
-    public void ConvertFrom_ShouldConvertKeys_Localization(string cultureName, string localizedKeyName, Keys expectedKey)
-    {
-        CultureInfo culture = CultureInfo.GetCultureInfo(cultureName);
-        KeysConverter converter = new();
-
-        // The 'localizedKeyName' is converted into the corresponding key value according to the specified culture.
-        var resultFromSpecificCulture = (Keys?)converter.ConvertFrom(context: null, culture, localizedKeyName);
-        Assert.Equal(expectedKey, resultFromSpecificCulture);
-
-        // Record original UI culture.
-        CultureInfo originalUICulture = Thread.CurrentThread.CurrentUICulture;
-
-        try
-        {
-            Thread.CurrentThread.CurrentUICulture = culture;
-
-            // When the culture is empty, the 'localizedKeyName' is converted to the corresponding key value based on CurrentUICulture.
-            var resultFromUICulture = (Keys?)converter.ConvertFrom(context: null, culture: null, localizedKeyName);
-            Assert.Equal(expectedKey, resultFromUICulture);
-        }
-        finally
-        {
-            Thread.CurrentThread.CurrentUICulture = originalUICulture;
-        }
-    }
-
     [Theory]
     [InlineData(Keys.None, "(none)")]
     [InlineData(Keys.S, "S")]
@@ -71,19 +41,6 @@ public void ConvertToString_ShouldConvertKeys(Keys keys, string expectedResult)
         Assert.Equal(expectedResult, result);
     }
 
-    [Theory]
-    [InlineData("fr-FR", Keys.None, "(aucune)")]
-    [InlineData("de-DE", Keys.End, "Ende")]
-    public void ConvertToString_ShouldConvertKeys_Localization(string cultureName, Keys key, string expectedLocalizedKeyName)
-    {
-        CultureInfo culture = CultureInfo.GetCultureInfo(cultureName);
-
-        KeysConverter converter = new();
-        string result = converter.ConvertToString(null, culture, key);
-
-        Assert.Equal(expectedLocalizedKeyName, result);
-    }
-
     public static IEnumerable<object[]> ConvertToEnumArray_ShouldConvertKeys_TestData()
     {
         yield return new object[] { "fr-FR", Keys.None, new Enum[] { Keys.None } };