Skip to content

Cannot enter characters when adding ToolStripMenuItem1 and then adding ToolStripMenuItem2 after pressing enter in DemoConsole application #13400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MelonWang1 opened this issue Apr 30, 2025 · 3 comments · May be fixed by #13420
Assignees
Labels
area-DesignerSupport 💥 regression-preview Regression from a preview release
Milestone

Comments

@MelonWang1
Copy link
Contributor

MelonWang1 commented Apr 30, 2025

.NET version

main branch of WinForms repo

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

Yes, this is a regression issue. Not repro on .NET 9.0 from Release/9.0 branch of WinForms repo.

release9.0.mp4

Issue description

Actual result:
Cannot enter characters when adding ToolStripMenuItem1 and then adding ToolStripMenuItem2 after pressing enter in DemoConsole application.

cannot.input.mp4

Expected result:
Characters can be entered when adding ToolStripMenuItem1 and then adding ToolStripMenuItem2 after pressing enter in DemoConsole application.

framework.not.repro.mp4

Steps to reproduce

Test sample: DemoConsole bases on main branch in Winforms repo.

More info:

  1. This issue rerpo in ContextMenuStrip/MenuStrip/ToolStrip/BindingNavigator control in DemoConsole application.
@MelonWang1 MelonWang1 added 💥 regression-preview Regression from a preview release untriaged The team needs to look at this issue in the next triage labels Apr 30, 2025
@merriemcgaw
Copy link
Member

@LeafShi1 can your team look into this one?

@merriemcgaw merriemcgaw added this to the 10 Preview5 milestone Apr 30, 2025
@Tanya-Solyanik Tanya-Solyanik removed the untriaged The team needs to look at this issue in the next triage label Apr 30, 2025
@ricardobossan
Copy link
Member

The issue is caused by commit #13034:
fix #12916 Cannot use down to expand ToolStripDropDownButton in toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1.

Still need to find a solution that resolves both this regression and the original problem from #12916 without reintroducing either.

git bisect log

git bisect start
status: waiting for both good and bad commits
good: [78c7bb8] System.Data.SqlClient - use version recommended by the SQL team, I couldn't find v5, not sure if it exists, we are not referencing this package right ow, so this is not a problem. Nuget.Packaging - use version that does not pull in vulnerable System.Formats.Asn1 (v8.0,0) Change in the VB test project - this assembly is not references directly, transitive versions can be resolved from the central packaging
git bisect good 78c7bb8
status: waiting for bad commit, 1 good commit known
bad: [9092b06] [main] Update dependencies from dotnet/runtime (#13363)
git bisect bad 9092b06
bad: [1a43082] Ensure that System.Drawing facade assembly is built before the tests that consume it are. (#13119)
git bisect bad 1a43082
bad: [1a43082] Ensure that System.Drawing facade assembly is built before the tests that consume it are. (#13119)
git bisect bad 1a43082
good: [707898d] [main] Update dependencies from dotnet/arcade (#13032)
git bisect good 707898d
bad: [316a77b] Remove extra dot at the end of resource string (#13091)
git bisect bad 316a77b
bad: [5e8147d] Resizes DemoConsole project's MainForm for convenience and to make everything visible in the surface designer (#13050)
git bisect bad 5e8147d
bad: [6e112b8] fix #12916 Cannot use down to expand ToolStripDropDownButton in toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1 (#13034)
git bisect bad 6e112b8
good: [e9f1c43] Enable nullability in DesignerActionMethodItem (#12676)
git bisect good e9f1c43
good: [e65c611] [main] Update dependencies from dotnet/arcade (#13038)
git bisect good e65c611
good: [2dc1fbe] Add code coverage for ControlCodeDomSerializer (#13011)
git bisect good 2dc1fbe
first bad commit: [6e112b8] fix #12916 Cannot use down to expand ToolStripDropDownButton in toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1 (#13034)

@ricardobossan
Copy link
Member

@Tanya-Solyanik I’ve confirmed this issue does not reproduce at design-time in Visual Studio.

I tested it by building the runtime at the commit from PR #13034 and replacing my local installation of Microsoft.WindowsDesktop.App with the modified DLLs. Then I created a new WinForms project targeting the latest SDK and verified the behavior in the designer:

Image

The issue only happens in the DemoConsole, not in actual design-time.

Should we consider this a won't fix, or would we want to address it specifically for DemoConsole?

Epica3055 added a commit to Epica3055/winforms that referenced this issue May 7, 2025
…m1 and then adding ToolStripMenuItem2 after pressing enter in DemoConsole application
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment