Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruby from 2.7.7 to 3.x latest #773

Open
compwron opened this issue Feb 18, 2023 · 6 comments
Open

Upgrade ruby from 2.7.7 to 3.x latest #773

compwron opened this issue Feb 18, 2023 · 6 comments

Comments

@compwron
Copy link
Member

Check .ruby-version for what ruby we are using. Look at https://www.ruby-lang.org/en/downloads/releases/ and upgrade one version per PR until we are at the latest mainstream supported version (currently 3.2.1).

@fchatterji
Copy link

Hey @compwron, can i work on this issue?

@compwron
Copy link
Member Author

@fchatterji go for it! :)

@fchatterji
Copy link

Hey, I tried to look at upgrading ruby, it creates a lot of errors in the test, that with my current knowledge of the codebase will be too long to fix. I just did the rails upgrade, will unassign myself from this issue.

@fchatterji fchatterji removed their assignment Feb 20, 2023
@compwron compwron changed the title Upgrade ruby Upgrade ruby from 2.7.7 to 3.x latest Apr 27, 2023
@sylphiae
Copy link
Contributor

I tried looking into upgrading Ruby and found that while the app ran locally fine, all of the tests failed. I added this gem to make the tests work "gem 'net-smtp', require: false" and then there were 45 failures. I think the stripe gem needs to be upgraded first because many of the failures were around the stripe tests.

@sylphiae
Copy link
Contributor

Failures:

  1. StripeEventHelper ChargeFailed with no Stripe customer ID #call sends an email
    Failure/Error: let(:event) { StripeMock.mock_webhook_event("charge.failed") }

    NoMethodError:
    undefined method `exists?' for File:Class

    /home/jenny/.rvm/gems/ruby-3.2.2/gems/stripe-ruby-mock-2.5.8/lib/stripe_mock/api/webhooks.rb:7:in `mock_webhook_payload'

    /home/jenny/.rvm/gems/ruby-3.2.2/gems/stripe-ruby-mock-2.5.8/lib/stripe_mock/api/webhooks.rb:34:in `mock_webhook_event'

    ./spec/helpers/stripe_event_helper_spec.rb:27:in `block (3 levels) in <top (required)>'

    ./spec/helpers/stripe_event_helper_spec.rb:49:in `block (4 levels) in <top (required)>'

@ItsElaineTime
Copy link

Related? #489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants