ISSUE-1616: Upgrade to node 16 (#1622)

Author: keeler

.github/workflows/tests.yml

@@ -17,10 +17,11 @@ jobs:
     name: Run tests
 
     strategy:
+      fail-fast: false
       matrix:
         node_version:
-          - 12
           - 14
+          - 16
 
     runs-on: ubuntu-latest
 
@@ -33,8 +34,13 @@ jobs:
         with:
           node-version: ${{matrix.node_version}}
 
+      # See https://github.com/npm/cli/issues/2610
+      - name: Workaround for Node 14
+        if: matrix.node_version == '14'
+        run: sed -i 's/git+ssh/git+https/g' package-lock.json
+
       - name: Install
-        run: npm install
+        run: npm ci
 
       - name: Test
         run: npm test
@@ -78,10 +84,10 @@ jobs:
       - name: Setup
         uses: actions/[email protected]
         with:
-          node-version: 12
+          node-version: 16
 
       - name: Install
-        run: npm install --ignore-scripts
+        run: npm ci --ignore-scripts
 
       - name: Run ESLint
         run: npm run lint

.nvmrc

@@ -1 +1 @@
-v12
+16.15.1

Dockerfile

@@ -15,7 +15,7 @@ RUN chown dr4ftuser -R .
 USER dr4ftuser
 
 # Install the dependencies
-RUN npm install
+RUN npm ci
 
 # Publish the port 1337
 EXPOSE 1337

README.md

@@ -64,9 +64,9 @@ It supports all their features, and many more.
 
 ### Native
 
-1) Install [Node.js](https://nodejs.org/en/download/) >= 12.0.0
+1) Install [Node.js](https://nodejs.org/en/download/) >= 16.0.0. Alternatively, install [nvm](https://github.com/nvm-sh/nvm) and then run `nvm use` in this repo, which will install the correct Node version for this repo as defined in the `.nvmrc` file.
 2) Run<br>
-`$ npm install`<br>
+`$ npm ci`<br>
 `$ npm run build`<br>
 `$ npm start`
 3) Visit [http://localhost:1337](http://localhost:1337)
@@ -131,7 +131,7 @@ Breakpoints for the frontend should be set in your browser console.
 
 Be a part of this project! You can run the test using the following.
 
-1. Install dependencies from package.json by running `npm install`
+1. Install dependencies from package.json by running `npm ci`
 2. Run the test via `npm test`
 3. Make some fun new modules!
 

config/app.js

@@ -1,4 +1,4 @@
-const joi = require("@hapi/joi");
+const joi = require("joi");
 
 const envVarsSchema = joi.object({
   PORT: joi.number()

config/logger.js

@@ -1,4 +1,4 @@
-const joi = require("@hapi/joi");
+const joi = require("joi");
 
 const envVarsSchema = joi.object({
   LOGGER_LEVEL: joi.string()