Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Required<GraphQLServerOptions> and remove DefaultGraphQLServerOptions class #461

Open
sgohlke opened this issue Feb 4, 2025 · 0 comments
Labels
v5 issues for v5.x release

Comments

@sgohlke
Copy link
Collaborator

sgohlke commented Feb 4, 2025

As DefaultGraphQLServerOptions is basically just the GraphQLServerOptions with all fields required we should check if we can use Required type instead, use a function to return the Required options and remove the DefaultGraphQLServerOptions class. This will most likely result in a breaking change if DefaultGraphQLServerOptions is no longer exported, thus a v5 ticket.

@sgohlke sgohlke added the v5 issues for v5.x release label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 issues for v5.x release
Projects
None yet
Development

No branches or pull requests

1 participant