Skip to content

Commit 4a72b40

Browse files
committed
moved drone stream rates parameters to the CommonMavLinkDrone class.
1 parent b15b70f commit 4a72b40

File tree

3 files changed

+12
-20
lines changed

3 files changed

+12
-20
lines changed

ServiceApp/src/org/droidplanner/services/android/core/drone/autopilot/apm/ArduPilot.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
import org.droidplanner.services.android.core.drone.DroneInterfaces;
5858
import org.droidplanner.services.android.core.drone.LogMessageListener;
5959
import org.droidplanner.services.android.core.drone.Preferences;
60-
import org.droidplanner.services.android.core.drone.autopilot.CommonMavLinkDrone;
60+
import org.droidplanner.services.android.core.drone.autopilot.generic.CommonMavLinkDrone;
6161
import org.droidplanner.services.android.core.drone.profiles.Parameters;
6262
import org.droidplanner.services.android.core.drone.profiles.VehicleProfile;
6363
import org.droidplanner.services.android.core.drone.variables.ApmModes;
@@ -69,7 +69,6 @@
6969
import org.droidplanner.services.android.core.drone.variables.Magnetometer;
7070
import org.droidplanner.services.android.core.drone.variables.MissionStats;
7171
import org.droidplanner.services.android.core.drone.variables.RC;
72-
import org.droidplanner.services.android.core.drone.variables.StreamRates;
7372
import org.droidplanner.services.android.core.drone.variables.calibration.AccelCalibration;
7473
import org.droidplanner.services.android.core.drone.variables.calibration.MagnetometerCalibrationImpl;
7574
import org.droidplanner.services.android.core.helpers.coordinates.Coord3D;
@@ -94,7 +93,6 @@ public abstract class ArduPilot extends CommonMavLinkDrone {
9493
private final Home home;
9594
private final Mission mission;
9695
private final MissionStats missionStats;
97-
private final StreamRates streamRates;
9896
private final GuidedPoint guidedPoint;
9997
private final AccelCalibration accelCalibrationSetup;
10098
private final WaypointManager waypointManager;
@@ -129,7 +127,6 @@ public ArduPilot(Context context, MAVLinkStreams.MAVLinkOutputStream mavClient,
129127
this.home = new Home(this);
130128
this.mission = new Mission(this);
131129
this.missionStats = new MissionStats(this);
132-
this.streamRates = new StreamRates(this);
133130
this.guidedPoint = new GuidedPoint(this, handler);
134131
this.accelCalibrationSetup = new AccelCalibration(this, handler);
135132
this.magCalibration = new MagnetometerCalibrationImpl(this);
@@ -235,11 +232,6 @@ public MissionStats getMissionStats() {
235232
return missionStats;
236233
}
237234

238-
@Override
239-
public StreamRates getStreamRates() {
240-
return streamRates;
241-
}
242-
243235
@Override
244236
public GuidedPoint getGuidedPoint() {
245237
return guidedPoint;

ServiceApp/src/org/droidplanner/services/android/core/drone/autopilot/CommonMavLinkDrone.java renamed to ServiceApp/src/org/droidplanner/services/android/core/drone/autopilot/generic/CommonMavLinkDrone.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.droidplanner.services.android.core.drone.autopilot;
1+
package org.droidplanner.services.android.core.drone.autopilot.generic;
22

33
import android.os.Bundle;
44
import android.text.TextUtils;
@@ -31,7 +31,9 @@
3131
import org.droidplanner.services.android.core.MAVLink.command.doCmd.MavLinkDoCmds;
3232
import org.droidplanner.services.android.core.drone.DroneEvents;
3333
import org.droidplanner.services.android.core.drone.DroneInterfaces;
34+
import org.droidplanner.services.android.core.drone.autopilot.MavLinkDrone;
3435
import org.droidplanner.services.android.core.drone.variables.State;
36+
import org.droidplanner.services.android.core.drone.variables.StreamRates;
3537
import org.droidplanner.services.android.core.drone.variables.Type;
3638
import org.droidplanner.services.android.core.model.AutopilotWarningParser;
3739
import org.droidplanner.services.android.utils.CommonApiUtils;
@@ -49,6 +51,7 @@ public abstract class CommonMavLinkDrone implements MavLinkDrone {
4951
private final DroneEvents events;
5052
protected final Type type;
5153
private final State state;
54+
private final StreamRates streamRates;
5255

5356
private final DroneInterfaces.AttributeEventListener attributeListener;
5457

@@ -64,6 +67,7 @@ protected CommonMavLinkDrone(DroneInterfaces.Handler handler, MAVLinkStreams.MAV
6467

6568
events = new DroneEvents(this, handler);
6669
this.type = new Type(this);
70+
this.streamRates = new StreamRates(this);
6771
this.state = new State(this, handler, warningParser);
6872

6973
this.attributeListener = listener;
@@ -84,6 +88,11 @@ public void addDroneListener(DroneInterfaces.OnDroneListener listener) {
8488
events.addDroneListener(listener);
8589
}
8690

91+
@Override
92+
public StreamRates getStreamRates() {
93+
return streamRates;
94+
}
95+
8796
@Override
8897
public void removeDroneListener(DroneInterfaces.OnDroneListener listener) {
8998
events.removeDroneListener(listener);

ServiceApp/src/org/droidplanner/services/android/core/drone/autopilot/px4/Px4Native.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
package org.droidplanner.services.android.core.drone.autopilot.px4;
22

3-
import com.o3dr.services.android.lib.model.ICommandListener;
4-
import com.o3dr.services.android.lib.model.action.Action;
5-
63
import org.droidplanner.services.android.core.MAVLink.MAVLinkStreams;
74
import org.droidplanner.services.android.core.MAVLink.WaypointManager;
85
import org.droidplanner.services.android.core.drone.DroneInterfaces;
96
import org.droidplanner.services.android.core.drone.Preferences;
10-
import org.droidplanner.services.android.core.drone.autopilot.CommonMavLinkDrone;
7+
import org.droidplanner.services.android.core.drone.autopilot.generic.CommonMavLinkDrone;
118
import org.droidplanner.services.android.core.drone.profiles.Parameters;
129
import org.droidplanner.services.android.core.drone.profiles.VehicleProfile;
1310
import org.droidplanner.services.android.core.drone.variables.Camera;
@@ -16,7 +13,6 @@
1613
import org.droidplanner.services.android.core.drone.variables.Home;
1714
import org.droidplanner.services.android.core.drone.variables.Magnetometer;
1815
import org.droidplanner.services.android.core.drone.variables.MissionStats;
19-
import org.droidplanner.services.android.core.drone.variables.StreamRates;
2016
import org.droidplanner.services.android.core.drone.variables.calibration.AccelCalibration;
2117
import org.droidplanner.services.android.core.drone.variables.calibration.MagnetometerCalibrationImpl;
2218
import org.droidplanner.services.android.core.firmware.FirmwareType;
@@ -97,11 +93,6 @@ public Mission getMission() {
9793
return null;
9894
}
9995

100-
@Override
101-
public StreamRates getStreamRates() {
102-
return null;
103-
}
104-
10596
@Override
10697
public MissionStats getMissionStats() {
10798
return null;

0 commit comments

Comments
 (0)