Skip to content

Commit 8122114

Browse files
committed
more bug fixes.
1 parent 4c954e7 commit 8122114

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

ServiceApp/src/org/droidplanner/services/android/communication/connection/usb/UsbCDCConnection.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
import java.util.concurrent.TimeUnit;
2020
import java.util.concurrent.atomic.AtomicReference;
2121

22+
import timber.log.Timber;
23+
2224
class UsbCDCConnection extends UsbConnection.UsbConnectionImpl {
2325
private static final String TAG = UsbCDCConnection.class.getSimpleName();
2426
private static final String ACTION_USB_PERMISSION = "com.android.example.USB_PERMISSION";
@@ -78,7 +80,11 @@ private void registerUsbPermissionBroadcastReceiver() {
7880
}
7981

8082
private void unregisterUsbPermissionBroadcastReceiver() {
81-
mContext.unregisterReceiver(broadcastReceiver);
83+
try {
84+
mContext.unregisterReceiver(broadcastReceiver);
85+
}catch(IllegalArgumentException e){
86+
Timber.e(e, "Receiver was not registered.");
87+
}
8288
}
8389

8490
private void removeWatchdog() {

ServiceApp/src/org/droidplanner/services/android/core/drone/DroneManager.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -521,6 +521,8 @@ private void handleCommandAck(msg_command_ack ack) {
521521
@Override
522522
public void notifyReceivedData(MAVLinkPacket packet) {
523523
MAVLinkMessage receivedMsg = packet.unpack();
524+
if(receivedMsg == null)
525+
return;
524526

525527
if (receivedMsg.msgid == msg_command_ack.MAVLINK_MSG_ID_COMMAND_ACK) {
526528
final msg_command_ack commandAck = (msg_command_ack) receivedMsg;

ServiceApp/src/org/droidplanner/services/android/core/gcs/GCSHeartbeat.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public GCSHeartbeat(MAVLinkClient mavClient, int freqHz) {
5858
*
5959
* @param active true to activate the heartbeat, false to deactivate it
6060
*/
61-
public void setActive(boolean active) {
61+
public synchronized void setActive(boolean active) {
6262
if (active) {
6363
if (heartbeatExecutor == null || heartbeatExecutor.isShutdown()) {
6464
heartbeatExecutor = Executors.newSingleThreadScheduledExecutor();

0 commit comments

Comments
 (0)