Fix sonarqube issues

Author: drsherlock

.eslintrc

@@ -14,6 +14,7 @@
   ],
   "rules": {
     '@typescript-eslint/no-non-null-assertion': 'off',
-     "quotes": ["error", "backtick"]
+     "quotes": ["error", "backtick"],
+     "no-constant-condition": ["error", { "checkLoops": false }]
   }
 }

src/Expense/ExpenseFactory.ts

@@ -13,13 +13,10 @@ class ExpenseFactory {
     switch (expenseType) {
       case `Equal`:
         return new EqualExpense(expenseName, paidBy, expenseAmount);
-        break;
       case `Unequal`:
         return new UnequalExpense(expenseName, paidBy, expenseAmount);
-        break;
       case `Percentage`:
         return new PercentageExpense(expenseName, paidBy, expenseAmount);
-        break;
       default:
         throw new Error(`Please select the type of expense`);
     }

src/Expenses/Expenses.ts

@@ -22,8 +22,8 @@ class Expenses implements IExpenses {
     );
 
     console.log(`Balances---`);
-    for (let i = 0; i < evaluatedLedger.length; i++) {
-      console.log(evaluatedLedger[i]);
+    for (const l of evaluatedLedger) {
+      console.log(l);
     }
   }
 }

src/UserPrompts.ts

@@ -123,9 +123,7 @@ export const getPaidBy = async (
       choices: Object.keys(personsMap),
     },
   ]);
-  const paidBy: string = userInput.paidBy;
-
-  return paidBy;
+  return userInput.paidBy;
 };
 
 export const getExpenseAmount = async (): Promise<number> => {
@@ -146,9 +144,7 @@ export const getExpenseAmount = async (): Promise<number> => {
 
 export const getExpenseType = async (): Promise<string> => {
   const userInput = await inquirer.prompt([prompts.EXPENSE_TYPE]);
-  const expenseType: string = userInput.expenseType;
-
-  return expenseType;
+  return userInput.expenseType;
 };
 
 export const getPersonPercentage = async (

src/app.ts

@@ -18,7 +18,7 @@ class Splitter {
       const expenses: IExpenses = new Expenses(personsMap);
 
       // get expenses
-      for (;;) {
+      while (1) {
         const addExpense = await UserPrompts.getAddExpense();
 
         if (!addExpense) {