Merge branch '8.x-1.x' of github.com:drupalcommerce/commerce_paypal into 2843999-ipn-handler

Author: vasike

config/schema/commerce_paypal.schema.yml

@@ -23,3 +23,18 @@ commerce_payment.commerce_payment_gateway.plugin.paypal_payments_pro:
     client_secret:
       type: string
       label: 'Client secret'
+commerce_payment.commerce_payment_gateway.plugin.paypal_payflow:
+  type: commerce_payment_gateway_configuration
+  mapping:
+    partner:
+      type: string
+      label: 'Partner'
+    vendor:
+      type: string
+      label: 'Vendor'
+    user:
+      type: string
+      label: 'User'
+    password:
+      type: string
+      label: 'Password'

src/Plugin/Commerce/PaymentGateway/ExpressCheckout.php

@@ -134,19 +134,20 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
   public function validateConfigurationForm(array &$form, FormStateInterface $form_state) {
     parent::validateConfigurationForm($form, $form_state);
 
-    if (!$form_state->getErrors()) {
+    if (!$form_state->getErrors() && $form_state->isSubmitted()) {
       $values = $form_state->getValue($form['#parents']);
       $this->configuration['api_username'] = $values['api_username'];
       $this->configuration['api_password'] = $values['api_password'];
       $this->configuration['signature'] = $values['signature'];
       $this->configuration['solution_type'] = $values['solution_type'];
-    }
-    $response = $this->doRequest([
-      'METHOD' => 'GetBalance',
-    ]);
 
-    if ($response['ACK'] != 'Success') {
-      $form_state->setError($form['api_username'], $this->t('Invalid API credentials.'));
+      $response = $this->doRequest([
+        'METHOD' => 'GetBalance',
+      ]);
+
+      if ($response['ACK'] != 'Success') {
+        $form_state->setError($form, $this->t('Invalid API credentials.'));
+      }
     }
   }