-
Notifications
You must be signed in to change notification settings - Fork 0
Description
packageSourceUrl is a new nuspec XML element required to be a URL in relation to nupkg's source, specifically the repository where files used to create the nupkg resides.
ferventcoder prefers packageSourceUrl to point to repo base URL, e.g.
https://github.com/ferventcoder/chocolatey-packages
Because if it changes, the link will be wrong
The lowest common denominator is to get folks to the repo, they should be able to get to the package files
Which brings up an important distinction - the link is for all the files, not just the nuspec
So technically it would be to the folder, not all the way to the nuspec. 😉
I'm happy with any appropriate link that gets me to the files
dtgm contests this:
- unlikely for link path to change
- user could still identify repo source from broken link and "
tnuspec"
dtgm prefers packageSourceUrl to repo specific URL containing the source files, e.g.
https://github.com/ferventcoder/chocolatey-packages/tree/master/automatic/_output/foobar2000/1.3.6
However there are additional issues with this method as well.
- The above URL may not necessarily be the exact files used to build the nupkg since the URL simply points to the latest commit tree, in this case: https://github.com/ferventcoder/chocolatey-packages/tree/e4f26c9e3982768cc60a0cb12be09780c4e2f146/automatic/_output/foobar2000/1.3.6
- a. Chocolatey,org packages are immutable once approved. Once this happens there shouldn't be any additional commits made to the files in that specific version directory.
b. Additionally, given git is a revision control system, it makes more sense for packages not to have a version subdir and track versions within git commit comments instead.
c. https://github.com/ferventcoder/chocolatey-packages/tree/master/automatic/_output/foobar2000 - The files in tree/master/automatic/_output/foobar2000/1.3.6 are sourced from tree/master/automatic/foobar2000/
Options:
https://github.com/ferventcoder/chocolatey-packages
https://github.com/ferventcoder/chocolatey-packages/tree/master/automatic/foobar2000
https://github.com/ferventcoder/chocolatey-packages/tree/master/automatic/_output/foobar2000
https://github.com/ferventcoder/chocolatey-packages/tree/master/automatic/_output/foobar2000/1.3.6