feat: adopt shared oracle price inspector

[Git-on-my-level]

Summary

• sync .shared to shared-hardhat-tools commit 9dfdf05 (oracle CLI feed filter + dependency peer updates)
• replace oracle price script with shared wrapper

Testing

• yarn hardhat run --network ronin_testnet scripts/oracle/show_oracle_prices.ts
• yarn hardhat test test/oracle_aggregator/OracleAggregator.ts

[claude]

Claude finished @Git-on-my-level's task —— View job

---

PR Code Review

Review Summary

I've completed a comprehensive review of this PR that adopts the shared oracle price inspector. Here's my analysis:

✅ Positive Changes

Code Quality & Architecture:

• Excellent refactoring: The replacement of the 185-line custom script with a 3-line wrapper demonstrates good code reuse
• Well-structured shared library: The oracle price functionality is well-organized into logical modules (cli.ts, runner.ts, asset-extractors.ts, etc.)
• Strong separation of concerns: Each module has a clear responsibility (CLI handling, asset extraction, deployment classification)
• Good error handling: Comprehensive try-catch blocks with meaningful error messages throughout runner.ts:136-151

Functionality Improvements:

• Enhanced asset discovery: The new asset-extractors.ts supports many more oracle types (API3, Redstone, Tellor, SafeRate, etc.) vs the original basic approach
• Better CLI interface: Commander.js integration provides professional CLI options (--json, --aggregators, --asset, etc.)
• Flexible configuration: Multiple config file locations supported in config-loader.ts:13-17

⚠️ Areas for Improvement

Error Handling & Robustness:

1. Unsafe type assertions: runner.ts:49 uses any type for ethers, should be properly typed
2. Silent failures: Asset extraction functions (asset-extractors.ts:43-137) use continue on errors without logging
3. Missing validation: No validation that aggregator addresses are valid Ethereum addresses before contract calls

Performance Considerations:

1. Sequential processing: runner.ts:242-263 processes aggregators sequentially instead of in parallel
2. Redundant contract calls: runner.ts:173-185 calls BASE_CURRENCY_UNIT for each wrapper without caching
3. Default chunk size: 300 might be too large for some networks, could cause timeouts

Security Concerns:

1. Dynamic imports: config-loader.ts:25 uses dynamic imports which could be a vector for code injection if config paths are user-controlled
2. Contract interaction: Direct contract calls without gas limit validation could potentially cause DoS

📋 Specific Issues

Type Safety:

// runner.ts:49 - Should use proper ethers typing
ethers: any; // ❌ 
// Should be:
ethers: typeof import('ethers');

Error Logging:

// asset-extractors.ts:45 - Silent error handling
if (!curveSection || typeof curveSection !== 'object') {
  return; // ❌ No logging
}

Performance:

// runner.ts:242-263 - Sequential processing
for (const aggregator of aggregators) { // ❌ Could be parallel
  const record = await inspectAggregator(...);
}

🧪 Test Coverage

Missing Tests:

• No unit tests found for the new oracle price functionality
• Original script had no tests either, so this is a pre-existing gap
• Recommendation: Add tests for asset extraction logic and error scenarios

Testing Command:

• The provided test command yarn hardhat run --network ronin_testnet scripts/oracle/show_oracle_prices.ts should work but requires network access

🔒 Security Assessment

Low Risk:

• Read-only operations (view/pure functions only)
• No state modifications or fund transfers
• Input validation present for basic types

Recommendations:

• Add address validation for user-provided asset addresses
• Consider adding rate limiting for contract calls
• Validate configuration data structure before processing

📊 Performance Impact

Improvements:

• Better asset discovery reduces manual configuration needs
• Chunk-based processing can handle large asset lists

Potential Issues:

• Sequential aggregator processing may be slower for multiple aggregators
• No connection pooling or batch optimization for RPC calls

🎯 Overall Assessment

Grade: B+

This is a solid refactoring that significantly improves code maintainability and functionality. The shared library approach is architecturally sound and the asset extraction logic is comprehensive. Main areas for improvement are error handling, type safety, and adding proper test coverage.

Recommendation: ✅ Approve with minor suggestions

The PR successfully achieves its goal of adopting shared oracle tooling while maintaining functionality. The code quality is good overall and the architectural improvements outweigh the minor issues identified.

---

[claude]

Claude finished @Git-on-my-level's task —— View job

---

PR Code Review - Shared Oracle Price Inspector

Review Tasks

• Analyze the main script replacement (show_oracle_prices.ts)
• Review shared oracle library implementation
• Evaluate code quality and architecture
• Assess security considerations
• Check for potential bugs and issues
• Analyze performance implications
• Review test coverage
• Provide final recommendations

---

✅ Excellent Refactoring Achievement

This PR successfully replaces a 185-line custom implementation with a 3-line wrapper that leverages shared oracle tooling. This is an exemplary refactoring that promotes code reuse and maintainability.

🏗️ Architecture & Code Quality

Strengths:

• Well-organized modular design: Clear separation of concerns across cli.ts, runner.ts, asset-extractors.ts, etc.
• Comprehensive asset discovery: The new system supports many more oracle types (API3, Redstone, Tellor, SafeRate, Curve) vs the original's basic pattern matching
• Professional CLI interface: Commander.js integration with proper options (--json, --aggregators, --asset, etc.)
• Flexible configuration: Multiple config file discovery paths in config-loader.ts:13-17
• Robust error handling: Try-catch blocks with meaningful error messages throughout

Areas for Improvement:

1. Type Safety Issues (runner.ts:49):

ethers: any; // ❌ Should use proper ethers typing

2. Silent Error Handling (asset-extractors.ts):

// Lines 44-46, 50-51, etc. - Functions use early returns without logging
if (!curveSection || typeof curveSection !== 'object') {
  return; // ❌ Silent failure
}

🐛 Potential Bugs & Issues

1. Address Validation Gap: No validation that user-provided asset addresses are valid Ethereum addresses before contract calls
2. Dynamic Import Security: config-loader.ts:25 uses dynamic imports which could be a vector if config paths are user-controlled
3. Default Chunk Size: runner.ts:26 defaults to 300 which might cause timeouts on slower networks
4. Contract Call Safety: Direct contract calls without gas limit validation

🚀 Performance Considerations

Improvements Over Original:

• Better asset discovery reduces manual configuration
• Chunk-based processing can handle large asset lists
• Comprehensive wrapper support vs basic pattern matching

Performance Issues:

1. Sequential Processing (runner.ts:242-263):

for (const aggregator of aggregators) { // ❌ Could be parallel
  const record = await inspectAggregator(...);
}

2. Redundant Contract Calls (runner.ts:173-185):

// BASE_CURRENCY_UNIT called for each wrapper without caching
const unit = await wrapperContract.getFunction('BASE_CURRENCY_UNIT').staticCall();

🔒 Security Assessment

Low Risk Profile:

• Read-only operations (view/pure functions only)
• No state modifications or fund transfers
• Basic input validation present

Recommendations:

• Add address format validation for user inputs
• Consider rate limiting for contract calls
• Validate configuration structure before processing

🧪 Test Coverage

Critical Gap: No unit tests found for the new oracle price functionality. The original script also lacked tests, but this shared library should have proper test coverage given its reusable nature.

Recommended Tests:

• Asset extraction logic (asset-extractors.ts)
• Error scenarios and edge cases
• Configuration loading and validation
• Price formatting and decimals handling

📊 Comparison: Old vs New Implementation

Aspect	Original (185 lines)	New (3 lines + shared)
Asset Discovery	Basic pattern matching	Comprehensive multi-oracle support
Error Handling	Basic try-catch	Detailed error tracking with notes
CLI Interface	Hardcoded behavior	Professional CLI with options
Maintainability	Single-repo specific	Shared across projects
Configuration	Hardcoded path	Flexible discovery mechanism

🎯 Final Recommendations

Grade: B+ ⭐

✅ Approve with Suggestions

This PR achieves its primary goal excellently. The architectural improvements and code reuse benefits significantly outweigh the minor issues identified.

Priority Fixes:

1. Add proper TypeScript typing for ethers (runner.ts:49)
2. Add logging for silent error cases in asset extractors
3. Consider parallel processing for performance improvement
4. Add basic unit tests for core functionality

Optional Enhancements:

• Address validation for user inputs
• Wrapper contract call caching
• Configurable chunk sizes based on network

The shared oracle tooling represents a significant improvement in code organization and functionality. The issues identified are minor and don't impact the core value proposition of this refactoring.

---

[claude]

Claude finished @Git-on-my-level's task —— View job

---

PR Code Review: Shared Oracle Price Inspector

Review Tasks

• Analyze the main script replacement (show_oracle_prices.ts)
• Review shared oracle library implementation
• Evaluate code quality and architecture
• Assess security considerations
• Check for potential bugs and issues
• Analyze performance implications
• Review test coverage
• Provide final recommendations

---

✅ Excellent Refactoring Achievement

This PR successfully replaces a 185-line custom oracle price script with a 3-line wrapper that leverages shared tooling - a textbook example of excellent code reuse and maintainability.

🏗️ Architecture & Code Quality - Grade: A-

Strengths:

• Excellent modular design: 6 focused modules with clear separation of concerns
• Professional CLI interface: Commander.js with comprehensive options (--json, --aggregators, --asset, etc.)
• Comprehensive asset discovery: Supports 7+ oracle types (API3, Redstone, Tellor, SafeRate, Curve, Chainlink, DEX) vs original's basic pattern matching
• Robust error handling: Try-catch blocks with detailed error tracking via notes system
• Smart deployment classification: ABI-based detection for aggregators vs wrappers
• Type safety: Well-defined interfaces in types.ts

🔒 Security Assessment - Grade: B+

Low Risk Profile (Read-only operations):

• ✅ Only view/pure function calls - no state modifications
• ✅ No fund transfers or sensitive operations
• ✅ Basic input validation present

Areas for Improvement:

1. Dynamic Import Risk (config-loader.ts:25): Could be exploited if config paths are user-controlled
2. Missing Address Validation: No validation that addresses are valid Ethereum addresses before contract calls
3. No Gas Limit Protection: Direct contract calls without gas limit validation

🐛 Potential Issues - Grade: B

Type Safety Issues:

• runner.ts:49 - ethers: any should use proper ethers typing
• Excessive any usage in asset extractors (lines 43, 61, 77, 86, 98, etc.)

Silent Error Handling:

• Asset extraction functions fail silently (asset-extractors.ts:45-46, 50-51, 54-55)
• Could hide configuration parsing issues without logging

🚀 Performance Analysis - Grade: B

Improvements Over Original:

• ✅ Better asset discovery reduces manual configuration
• ✅ Wrapper contract unit caching (runner.ts:153)
• ✅ Chunk-based processing capability

Performance Issues:

1. Sequential Processing (runner.ts:242-263): Aggregators processed sequentially instead of parallel
2. Redundant Contract Calls: BASE_CURRENCY_UNIT called for each wrapper without cross-wrapper caching
3. Default Chunk Size: 300 might cause timeouts on slower networks

🧪 Test Coverage - Grade: D

Critical Gap: No unit tests found for the new oracle price functionality

• ❌ Original script had no tests, but shared library should have proper coverage
• ❌ No tests for asset extraction logic, error scenarios, or configuration loading
• ✅ Oracle contracts have existing tests in test/oracle_aggregator/ but not for this inspection library

Recommended Tests:

• Asset extraction logic validation
• Error scenarios and edge cases
• Configuration loading and validation
• Price formatting and decimals handling

🎯 Final Recommendations - Overall Grade: B+

✅ Approve with Suggestions

This PR achieves its primary goal excellently. The architectural improvements and code reuse benefits significantly outweigh the minor issues identified.

Priority Fixes:

1. Add proper TypeScript typing for ethers (runner.ts:49)
2. Add logging for silent error cases in asset extractors
3. Consider parallel processing for performance improvement
4. Add basic unit tests for core functionality

Optional Enhancements:

• Address validation for user inputs
• Cross-wrapper contract call caching optimization
• Configurable chunk sizes based on network
• Rate limiting for contract calls

The shared oracle tooling represents a significant improvement in code organization and functionality. The issues identified are minor and don't impact the core value proposition of this refactoring.

---

[claude]

Claude finished @Git-on-my-level's task —— View job

---

PR Code Review: Shared Oracle Price Inspector

Review Tasks

• Analyze the main script replacement (show_oracle_prices.ts)
• Review shared oracle library implementation
• Evaluate code quality and architecture
• Assess security considerations
• Check for potential bugs and issues
• Analyze performance implications
• Review test coverage
• Provide final recommendations

---

✅ Excellent Refactoring Achievement

This PR successfully replaces a 186-line custom oracle price script with a 3-line wrapper that leverages shared tooling - a textbook example of excellent code reuse and maintainability.

🏗️ Architecture & Code Quality - Grade: A-

Excellent modular design with clear separation of concerns:

• cli.ts - Professional Commander.js CLI with comprehensive options
• runner.ts - Core inspection logic with proper error handling
• asset-extractors.ts - Comprehensive asset discovery for 7+ oracle types
• types.ts - Well-defined TypeScript interfaces
• config-loader.ts - Flexible configuration discovery
• deployment-classifier.ts - Smart ABI-based contract classification

Major Improvements Over Original:

• ✅ Comprehensive oracle support: API3, Redstone, Tellor, SafeRate, Curve, Chainlink, DEX vs basic pattern matching
• ✅ Professional CLI: Multiple output formats (--json), filtering options
• ✅ Robust error handling: Try-catch blocks with detailed error tracking via notes system
• ✅ Smart deployment discovery: ABI-based classification and multiple deployment name candidates
• ✅ Type safety: Well-defined interfaces throughout

🔒 Security Assessment - Grade: B+

Low Risk Profile (Read-only operations):

• ✅ Only view/pure function calls - no state modifications
• ✅ No fund transfers or sensitive operations
• ✅ Basic input validation present

Areas for Improvement:

1. Dynamic Import Risk (config-loader.ts:25): Could be exploited if config paths are user-controlled
2. Missing Address Validation: No validation that addresses are valid Ethereum addresses before contract calls
3. No Gas Limit Protection: Direct contract calls without gas limit validation

🐛 Potential Issues - Grade: B

Type Safety Issues:

• runner.ts:49 - ethers: any should use proper ethers typing
• Excessive any usage in asset extractors (functions accept any for config sections)

Silent Error Handling:

• Asset extraction functions fail silently with continue statements (asset-extractors.ts:30, 51, 55)
• Could hide configuration parsing issues without logging

Missing Validation:

• No address format validation before contract interactions
• No network compatibility checks

🚀 Performance Analysis - Grade: B

Improvements Over Original:

• ✅ Better asset discovery reduces manual configuration
• ✅ Wrapper contract unit caching (runner.ts:153)
• ✅ Chunk-based processing capability

Performance Issues:

1. Sequential Processing (runner.ts:242-263): Aggregators processed sequentially instead of parallel
2. Redundant Contract Calls: BASE_CURRENCY_UNIT called for each wrapper without cross-wrapper caching
3. Default Chunk Size: 300 might cause timeouts on slower networks

🧪 Test Coverage - Grade: D

Critical Gap: No unit tests found for the new oracle price functionality

• ❌ Original script had no tests, but shared library should have proper coverage
• ❌ No tests for asset extraction logic, error scenarios, or configuration loading
• ✅ Oracle contracts have existing tests in test/oracle_aggregator/ but not for this inspection library

🎯 Final Recommendations - Overall Grade: B+

✅ Approve with Suggestions

This PR achieves its primary goal excellently. The architectural improvements and code reuse benefits significantly outweigh the minor issues identified.

Priority Fixes:

1. Add proper TypeScript typing for ethers (runner.ts:49)
2. Add logging for silent error cases in asset extractors
3. Consider parallel processing for performance improvement
4. Add basic unit tests for core functionality

Optional Enhancements:

• Address validation for user inputs
• Cross-wrapper contract call caching optimization
• Configurable chunk sizes based on network
• Rate limiting for contract calls

Code Quality Comparison:

Aspect	Original (186 lines)	New (3 lines + shared)
Asset Discovery	Basic pattern matching	Comprehensive multi-oracle support
Error Handling	Basic try-catch	Detailed error tracking with notes
CLI Interface	Hardcoded behavior	Professional CLI with options
Maintainability	Single-repo specific	Shared across projects
Type Safety	Mixed	Good interfaces, some any usage

The shared oracle tooling represents a significant improvement in code organization and functionality. The issues identified are minor and don't impact the core value proposition of this refactoring.

---

[claude]

Claude finished @Git-on-my-level's task —— View job

---

PR Code Review: Shared Oracle Price Inspector

Review Tasks

• Analyze the main script replacement (show_oracle_prices.ts)
• Review shared oracle library implementation
• Evaluate code quality and architecture
• Assess security considerations
• Check for potential bugs and issues
• Analyze performance implications
• Review test coverage
• Provide final recommendations

---

✅ Excellent Refactoring Achievement

This PR successfully replaces a 185-line custom oracle price script with a 3-line wrapper that leverages shared tooling - a textbook example of excellent code reuse and maintainability.

🏗️ Architecture & Code Quality - Grade: A-

Excellent modular design with clear separation of concerns:

• cli.ts - Professional Commander.js CLI with comprehensive options
• runner.ts - Core inspection logic with proper error handling
• asset-extractors.ts - Comprehensive asset discovery for 7+ oracle types
• types.ts - Well-defined TypeScript interfaces
• config-loader.ts - Flexible configuration discovery
• deployment-classifier.ts - Smart ABI-based contract classification

Major Improvements Over Original:

• ✅ Comprehensive oracle support: API3, Redstone, Tellor, SafeRate, Curve, Chainlink, DEX vs basic pattern matching
• ✅ Professional CLI: Multiple output formats (--json), filtering options (--aggregators, --asset)
• ✅ Robust error handling: Try-catch blocks with detailed error tracking via notes system
• ✅ Smart deployment discovery: ABI-based classification and multiple deployment name candidates
• ✅ Type safety: Well-defined interfaces throughout

🔒 Security Assessment - Grade: B+

Low Risk Profile (Read-only operations):

• ✅ Only view/pure function calls - no state modifications
• ✅ No fund transfers or sensitive operations
• ✅ Basic input validation present

Areas for Improvement:

1. Dynamic Import Risk (config-loader.ts:25): Could be exploited if config paths are user-controlled
2. Missing Address Validation: No validation that addresses are valid Ethereum addresses before contract calls
3. No Gas Limit Protection: Direct contract calls without gas limit validation

🐛 Potential Issues - Grade: B

Type Safety Issues:

• runner.ts:49 - ethers: any should use proper ethers typing
• Excessive any usage in asset extractors (functions accept any for config sections)

Silent Error Handling:

• Asset extraction functions fail silently with continue statements (asset-extractors.ts:30, 51, 55)
• Could hide configuration parsing issues without logging

Missing Validation:

• No address format validation before contract interactions
• No network compatibility checks

🚀 Performance Analysis - Grade: B

Improvements Over Original:

• ✅ Better asset discovery reduces manual configuration
• ✅ Wrapper contract unit caching (runner.ts:153)
• ✅ Chunk-based processing capability

Performance Issues:

1. Sequential Processing (runner.ts:242-263): Aggregators processed sequentially instead of parallel
2. Redundant Contract Calls: BASE_CURRENCY_UNIT called for each wrapper without cross-wrapper caching
3. Default Chunk Size: 300 might cause timeouts on slower networks

🧪 Test Coverage - Grade: D

Critical Gap: No unit tests found for the new oracle price functionality

• ❌ Original script had no tests, but shared library should have proper coverage
• ❌ No tests for asset extraction logic, error scenarios, or configuration loading
• ✅ Oracle contracts have existing tests in test/oracle_aggregator/ but not for this inspection library

🎯 Final Recommendations - Overall Grade: B+

✅ Approve with Suggestions

This PR achieves its primary goal excellently. The architectural improvements and code reuse benefits significantly outweigh the minor issues identified.

Priority Fixes:

1. Add proper TypeScript typing for ethers (runner.ts:49)
2. Add logging for silent error cases in asset extractors
3. Consider parallel processing for performance improvement
4. Add basic unit tests for core functionality

Optional Enhancements:

• Address validation for user inputs
• Cross-wrapper contract call caching optimization
• Configurable chunk sizes based on network
• Rate limiting for contract calls

Code Quality Comparison:

Aspect	Original (185 lines)	New (3 lines + shared)
Asset Discovery	Basic pattern matching	Comprehensive multi-oracle support
Error Handling	Basic try-catch	Detailed error tracking with notes
CLI Interface	Hardcoded behavior	Professional CLI with options
Maintainability	Single-repo specific	Shared across projects
Type Safety	Mixed	Good interfaces, some any usage

The shared oracle tooling represents a significant improvement in code organization and functionality. The issues identified are minor and don't impact the core value proposition of this refactoring.

---

[claude]

Claude finished @Git-on-my-level's task —— View job

---

PR Code Review: Shared Oracle Price Inspector

Review Tasks

• Analyze the main script replacement (show_oracle_prices.ts)
• Review shared oracle library implementation
• Evaluate code quality and architecture
• Assess security considerations
• Check for potential bugs and issues
• Analyze performance implications
• Review test coverage
• Provide final recommendations

---

✅ Excellent Refactoring Achievement

This PR successfully replaces a 185-line custom oracle price script with a 3-line wrapper that leverages shared tooling - a textbook example of excellent code reuse and maintainability.

🏗️ Architecture & Code Quality - Grade: A-

Excellent modular design with clear separation of concerns:

• cli.ts - Professional Commander.js CLI with comprehensive options
• runner.ts - Core inspection logic with proper error handling
• asset-extractors.ts - Comprehensive asset discovery for 7+ oracle types
• types.ts - Well-defined TypeScript interfaces
• config-loader.ts - Flexible configuration discovery
• deployment-classifier.ts - Smart ABI-based contract classification

Major Improvements Over Original:

• ✅ Comprehensive oracle support: API3, Redstone, Tellor, SafeRate, Curve, Chainlink, DEX vs basic pattern matching
• ✅ Professional CLI: Multiple output formats (--json), filtering options (--aggregators, --asset)
• ✅ Robust error handling: Try-catch blocks with detailed error tracking via notes system
• ✅ Smart deployment discovery: ABI-based classification and multiple deployment name candidates
• ✅ Type safety: Well-defined interfaces throughout

🔒 Security Assessment - Grade: B+

Low Risk Profile (Read-only operations):

• ✅ Only view/pure function calls - no state modifications
• ✅ No fund transfers or sensitive operations
• ✅ Basic input validation present

Areas for Improvement:

1. Dynamic Import Risk (config-loader.ts:25): Could be exploited if config paths are user-controlled
2. Missing Address Validation: No validation that addresses are valid Ethereum addresses before contract calls
3. No Gas Limit Protection: Direct contract calls without gas limit validation

🐛 Potential Issues - Grade: B

Type Safety Issues:

• runner.ts:49 - ethers: any should use proper ethers typing
• Excessive any usage in asset extractors (functions accept any for config sections)

Silent Error Handling:

• Asset extraction functions fail silently with continue statements (asset-extractors.ts:30, 51, 55)
• Could hide configuration parsing issues without logging

Missing Validation:

• No address format validation before contract interactions
• No network compatibility checks

🚀 Performance Analysis - Grade: B

Improvements Over Original:

• ✅ Better asset discovery reduces manual configuration
• ✅ Wrapper contract unit caching (runner.ts:153)
• ✅ Chunk-based processing capability

Performance Issues:

1. Sequential Processing (runner.ts:242-263): Aggregators processed sequentially instead of parallel
2. Redundant Contract Calls: BASE_CURRENCY_UNIT called for each wrapper without cross-wrapper caching
3. Default Chunk Size: 300 might cause timeouts on slower networks

🧪 Test Coverage - Grade: D

Critical Gap: No unit tests found for the new oracle price functionality

• ❌ Original script had no tests, but shared library should have proper coverage
• ❌ No tests for asset extraction logic, error scenarios, or configuration loading
• ✅ Oracle contracts have existing tests in test/oracle_aggregator/ but not for this inspection library

🎯 Final Recommendations - Overall Grade: B+

✅ Approve with Suggestions

This PR achieves its primary goal excellently. The architectural improvements and code reuse benefits significantly outweigh the minor issues identified.

Priority Fixes:

1. Add proper TypeScript typing for ethers (runner.ts:49)
2. Add logging for silent error cases in asset extractors
3. Consider parallel processing for performance improvement
4. Add basic unit tests for core functionality

Optional Enhancements:

• Address validation for user inputs
• Cross-wrapper contract call caching optimization
• Configurable chunk sizes based on network
• Rate limiting for contract calls

Code Quality Comparison:

Aspect	Original (185 lines)	New (3 lines + shared)
Asset Discovery	Basic pattern matching	Comprehensive multi-oracle support
Error Handling	Basic try-catch	Detailed error tracking with notes
CLI Interface	Hardcoded behavior	Professional CLI with options
Maintainability	Single-repo specific	Shared across projects
Type Safety	Mixed	Good interfaces, some any usage

The shared oracle tooling represents a significant improvement in code organization and functionality. The issues identified are minor and don't impact the core value proposition of this refactoring.

---