Support building on Android #402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `-stdlib=libstdc++` flag on Android since it breaks the build * Add `bundled-android-static-libstdcpp` feature for selecting the static C++ runtime (I.e. https://developer.android.com/ndk/guides/cpp-support#use_clang_directly)
|
I'd like to merge this if possible. Could I please get approval to run workflows? Thanks. |
|
Thanks for the PR. Considering that Android support is still experimental, I'd like to avoid adding special compiler/linker flags that can affect other targets as hard-coded values to build.rs. The good news is that we use the cc crate in build.rs, which allows you to override specific flags for your particular use case, e.g. via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-stdlib=libstdc++flag on Android since it breaks the buildbundled-android-static-libstdcppfeature for selecting the static C++ runtime (I.e. https://developer.android.com/ndk/guides/cpp-support#use_clang_directly)I'm open to better name suggestions for
bundled-android-static-libstdcpp. I don't know enough about clang/LLVM to know what the implications of that flag outside of Android are, but it's specifically mentioned at the above link for selecting a static runtime on Android so I wanted to make the feature clear and explicitly scoped.