Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit 8ea60df

Browse files
authored
fixes button movement from home/web to tabswitcher (#3955)
Task/Issue URL: https://app.asana.com/0/0/1209358244103060/f Tech Design URL: CC: **Description**: Fix fire button movement by adding some padding to the fire button image. **Steps to test this PR**: 1. Open the tab switcher and make sure the fire button doesn't appear to move. 2. Check on a couple of different phone types. Can ignore SE as that has had a up/down movement problem for some time. **Definition of Done (Internal Only)**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?
1 parent c47657b commit 8ea60df

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"images" : [
3+
{
4+
"filename" : "fire_2.pdf",
5+
"idiom" : "universal"
6+
}
7+
],
8+
"info" : {
9+
"author" : "xcode",
10+
"version" : 1
11+
},
12+
"properties" : {
13+
"template-rendering-intent" : "template"
14+
}
15+
}
Binary file not shown.

DuckDuckGo/TabSwitcherViewController+MultiSelect.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ extension TabSwitcherViewController {
489489
self.addNewTab()
490490
})
491491

492-
barsHandler.fireButton.primaryAction = action(image: "Fire") { [weak self] in
492+
barsHandler.fireButton.primaryAction = action(image: "FireLeftPadded") { [weak self] in
493493
guard let self else { return }
494494
self.burn(sender: self.barsHandler.fireButton)
495495
}

0 commit comments

Comments
 (0)