fix: remove isomorphic-unfetch and use node-fetch instead (#375)

Author: Igo Lapa

jest.config.ts

@@ -1,4 +1,9 @@
 export default {
   clearMocks: true,
   testEnvironment: 'node',
+  transform: {
+    '^.+\\.(ts|tsx)$': 'ts-jest',
+    '^.+\\.(js)$': 'babel-jest',
+  },
+  transformIgnorePatterns: [],
 }

package.json

@@ -48,7 +48,7 @@
   },
   "dependencies": {
     "@types/node": "^17.0.1",
-    "isomorphic-unfetch": "^3.1.0"
+    "node-fetch": "^3.2.0"
   },
   "devDependencies": {
     "@babel/core": "^7.15.5",
@@ -59,7 +59,7 @@
     "@commitlint/cz-commitlint": "^16.0.0",
     "@rollup/plugin-commonjs": "^21.0.0",
     "@rollup/plugin-multi-entry": "^4.0.0",
-    "@rollup/plugin-node-resolve": "^13.0.0",
+    "@rollup/plugin-node-resolve": "^13.1.3",
     "@types/jest": "^27.0.1",
     "@typescript-eslint/eslint-plugin": "^4.26.1",
     "@typescript-eslint/parser": "^4.26.1",
@@ -74,8 +74,8 @@
     "lint-staged": "^12.0.1",
     "nock": "^13.1.0",
     "prettier": "^2.4.1",
-    "rollup": "^2.51.2",
-    "rollup-plugin-dts": "^4.0.0",
+    "rollup": "^2.66.1",
+    "rollup-plugin-dts": "^4.1.0",
     "rollup-plugin-inject-process-env": "^1.3.1",
     "rollup-plugin-peer-deps-external": "^2.2.4",
     "rollup-plugin-terser": "^7.0.2",
@@ -91,17 +91,17 @@
   "engines": {
     "node": ">=14.*"
   },
-  "plugins": [
-    [
-      "@semantic-release/commit-analyzer"
-    ],
-    [
-      "@semantic-release/release-notes-generator"
-    ],
-    "@semantic-release/npm",
-    "@semantic-release/github"
-  ],
   "release": {
+    "plugins": [
+      [
+        "@semantic-release/commit-analyzer"
+      ],
+      [
+        "@semantic-release/release-notes-generator"
+      ],
+      "@semantic-release/npm",
+      "@semantic-release/github"
+    ],
     "branches": [
       "main"
     ]

rollup.config.js

@@ -20,19 +20,23 @@ export default [
     input: 'src/index.ts',
     output: [
       {
+        inlineDynamicImports: true,
         file: packageJson.main,
         format: 'cjs', // commonJS
         sourcemap: true,
       },
       {
+        inlineDynamicImports: true,
         file: packageJson.module,
         format: 'esm', // ES Modules
         sourcemap: true,
       },
     ],
     plugins: [
       peerDepsExternal(),
-      resolve(),
+      resolve({
+        preferBuiltins: true,
+      }),
       commonjs(),
       typescript({
         clean: true,
@@ -46,12 +50,25 @@ export default [
       }),
       terser(),
     ],
-    external: Object.keys(globals),
+    external: [
+      ...Object.keys(globals),
+      'node:stream',
+      'node:http',
+      'node:zlib',
+      'node:buffer',
+      'node:https',
+      'node:util',
+      'node:url',
+      'node:net',
+      'node:path',
+      'node:fs',
+    ],
   },
   {
     input: ['dist/index.d.ts', 'dist/types/index.d.ts'],
     output: {
       format: 'es',
+      inlineDynamicImports: true,
       file: packageJson.types,
     },
     plugins: [multi(), dts()],

src/Client.ts

@@ -1,4 +1,4 @@
-import fetch from 'isomorphic-unfetch'
+import fetch from 'node-fetch'
 import { URL, URLSearchParams } from 'url'
 import { DuffelError, DuffelResponse, SDKOptions } from './types'
 

src/booking/OfferRequests/OfferRequests.spec.ts

@@ -108,6 +108,8 @@ describe('OfferRequests', () => {
 
   test('should create an offer request and return the offer request id when `return_offers` is false', async () => {
     const mockResponseWithoutOffer = { ...mockOfferRequest }
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+    //@ts-ignore
     delete mockResponseWithoutOffer.offers
     nock(/(.*)/)
       .post(`/air/offer_requests/`)