Skip to content

dumper stopped working after upgrading to Rails 6.1  #14

Open
@nanophate

Description

@nanophate

We recently checked on our dumper.io information and realized that few of the apps were not backed up. It seems like the back up stopped after we raise the rails version to 6.1. It would be great if the team can take a look at it.

=> Booting Puma
=> Rails 6.1.7 application starting in development 
=> Run `bin/rails server --help` for more startup options
[2023-01-02T16:37:29 (40935)] DEBUG : ** [Dumper] stack: {:framework=>:rails, :rails_env=>"development", :rails_version=>"6.1.7", :dispatcher=>:puma, :configs=>{}} - supported: false
[40935] Puma starting in cluster mode...
[40935] * Puma version: 5.6.5 (ruby 3.1.2-p20) ("Birdie's Version")
[40935] *  Min threads: 5
[40935] *  Max threads: 5
[40935] *  Environment: development
[40935] *   Master PID: 40935
[40935] *      Workers: 2
[40935] *     Restarts: () hot () phased
[40935] * Preloading application
[40935] * Listening on http://127.0.0.1:3000
[40935] * Listening on http://[::1]:3000
[40935] Use Ctrl-C to stop
[40935] - Worker 0 (PID: 40984) booted in 0.04s, phase: 0
[40935] - Worker 1 (PID: 40985) booted in 0.03s, phase: 0

Issue

It looks like the issue is caused by config['adapter'] returning nil. Seems like the following pr changed the rails/rails#37185 returning to symbol and confirmed that config[:adapter] works.

(config['adapter'] == 'postgresql')

[5] pry(#<Dumper::Database::PostgreSQL>)> config = ActiveRecord::Base.configurations[rails_env]
=> {:adapter=>"postgresql", :encoding=>"utf8", :pool=>5, :database=>"xxxx_jp_web_development"}
[6] pry(#<Dumper::Database::PostgreSQL>)> config['adapter'] == 'postgresql'
=> false
[7] pry(#<Dumper::Database::PostgreSQL>)> config['adapter']
=> nil
[8] pry(#<Dumper::Database::PostgreSQL>)> config
=> {:adapter=>"postgresql", :encoding=>"utf8", :pool=>5, :database=>"xxxx_jp_web_development"}
[9] pry(#<Dumper::Database::PostgreSQL>)> config[:adapter]
=> "postgresql"
[10] pry(#<Dumper::Database::PostgreSQL>)> config[:adapter] == 'postgresql'
=> true

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions