Update pre-commit and run it

Moustachauve · Moustachauve · commit 26099aff305d · 2025-02-28T04:43:05.000Z
diff --git a/.bandit.yaml b/.bandit.yaml
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -1,3 +1,4 @@
+---
 version: 2
 updates:
   - package-ecosystem: github-actions
diff --git a/.github/release-drafter.yml b/.github/release-drafter.yml
@@ -1,3 +1,4 @@
+---
 categories:
   - title: ":boom: Breaking Changes"
     label: "breaking"
diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml
@@ -1,5 +1,7 @@
+---
 name: Manage labels
 
+# yamllint disable-line rule:truthy
 on:
   push:
     branches:
diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml
@@ -1,4 +1,7 @@
+---
 name: Draft a release note
+
+# yamllint disable-line rule:truthy
 on:
   push:
     branches:
diff --git a/.gitignore b/.gitignore
@@ -138,4 +138,4 @@ dmypy.json
 .npm
 
 # Dependency directories
-node_modules/
+node_modules/
diff --git a/README.md b/README.md
@@ -86,4 +86,4 @@ check [the contributor's page][contributors].
 [pre-commit]: https://pre-commit.com/
 [dvd-dev]: https://github.com/dvd-dev
 [frenck]: https://github.com/frenck
-[contributors]: https://github.com/dvd-dev/python-hilo/graphs/contributors
+[contributors]: https://github.com/dvd-dev/python-hilo/graphs/contributors
diff --git a/doc/ChallengeAdded.json b/doc/ChallengeAdded.json
@@ -22,4 +22,4 @@
         }
       }
     ]
-  }
+  }
diff --git a/doc/ChallengeConsumptionUpdatedValuesReceived.json b/doc/ChallengeConsumptionUpdatedValuesReceived.json
@@ -976,4 +976,4 @@
         ]
       }
     ]
-  }
+  }
diff --git a/doc/ChallengeDetailsInitialValuesReceived.json b/doc/ChallengeDetailsInitialValuesReceived.json
@@ -170,4 +170,4 @@
         }
       }
     ]
-  }
+  }
diff --git a/doc/ChallengeListInitialValuesReceived.json b/doc/ChallengeListInitialValuesReceived.json
@@ -22,4 +22,4 @@
         }
       ]
     ]
-  }
+  }
diff --git a/doc/ChallengeListUpdatedValuesReceived.json b/doc/ChallengeListUpdatedValuesReceived.json
@@ -12,4 +12,4 @@
       }
     ]
   ]
-}
+}
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyhilo/__init__.py b/pyhilo/__init__.py
@@ -1,3 +1,4 @@
 """Define the hilo package."""
+
 from pyhilo.api import API  # noqa
 from pyhilo.devices import Devices  # noqa
diff --git a/pyhilo/const.py b/pyhilo/const.py
@@ -269,3 +269,6 @@
     "43094",
     "43100",
 ]
+
+# Should be kept in sync with homeassistant.const.STATE_UNKNOWN
+STATE_UNKNOWN: Final = "unknown"
diff --git a/pyhilo/device/__init__.py b/pyhilo/device/__init__.py
@@ -1,11 +1,12 @@
 """Define devices"""
+
 from __future__ import annotations
 
 from dataclasses import dataclass, field
 from datetime import datetime
 from typing import TYPE_CHECKING, Any, Dict, Union, cast
 
-from homeassistant.const import STATE_UNKNOWN
+from pyhilo.const import STATE_UNKNOWN
 
 from pyhilo.const import (
     HILO_DEVICE_ATTRIBUTES,
@@ -70,7 +71,7 @@ def update(self, **kwargs: Dict[str, Union[str, int, Dict]]) -> None:
             if att not in HILO_DEVICE_ATTRIBUTES:
                 LOG.warning(f"Unknown device attribute {att}: {val}")
                 continue
-            elif att in HILO_LIST_ATTRIBUTES:
+            if att in HILO_LIST_ATTRIBUTES:
                 # This is where we generated the supported_attributes and settable_attributes
                 # list using the DeviceAttribute object.
                 new_val: list[DeviceAttribute] = [
@@ -85,7 +86,8 @@ def update(self, **kwargs: Dict[str, Union[str, int, Dict]]) -> None:
                     new_val.append(DeviceAttribute("Disconnected", "null"))
             elif att == "provider":
                 att = "manufacturer"
-                new_val = HILO_PROVIDERS.get(int(val), f"Unknown ({val})")  # type: ignore
+                new_val = HILO_PROVIDERS.get(
+                    int(val), f"Unknown ({val})")  # type: ignore
             else:
                 if att == "serial":
                     att = "identifier"
@@ -122,17 +124,16 @@ async def _set_attribute(
             # succeed and we will get a reading back form signalR. This avoids ui flickering.
             self.update_readings(
                 DeviceReading(
-                    **{
-                        "deviceId": self.id,
-                        "locationId": self.location_id,
-                        "timeStampUTC": datetime.utcnow().isoformat(),
-                        "value": value,
-                        "device_attribute": attribute,
-                    }  # type: ignore
+                    deviceId=self.id,
+                    locationId=self.location_id,
+                    timeStampUTC=datetime.utcnow().isoformat(),
+                    value=value,
+                    device_attribute=attribute,  # type: ignore
                 )
             )
         else:
-            LOG.warning(f"{self._tag} Invalid attribute {attribute} for device")
+            LOG.warning(
+                f"{self._tag} Invalid attribute {attribute} for device")
 
     def get_attribute(self, attribute: str) -> Union[DeviceReading, None]:
         if dev_attribute := cast(DeviceAttribute, self._api.dev_atts(attribute)):
@@ -152,7 +153,7 @@ def has_attribute(self, attr: str) -> bool:
         return next((True for k in self.supported_attributes if k.attr == attr), False)
 
     def get_value(
-        self, attribute: str, default: Union[str, int, float, None] = STATE_UNKNOWN
+        self, attribute: str, default: Union[str, float, None] = STATE_UNKNOWN
     ) -> Any:
         attr = self.get_attribute(attribute)
         return attr.value if attr else default
@@ -230,7 +231,8 @@ def __init__(self, **kwargs: Dict[str, Any]):
         #       attr='intensity',
         #       value_type='%')
         # }
-        kwargs["timeStamp"] = from_utc_timestamp(kwargs.pop("timeStampUTC", ""))  # type: ignore
+        kwargs["timeStamp"] = from_utc_timestamp(
+            kwargs.pop("timeStampUTC", ""))  # type: ignore
         self.id = 0
         self.value: Union[int, bool, str] = 0
         self.device_id = 0
@@ -242,7 +244,8 @@ def __init__(self, **kwargs: Dict[str, Any]):
             else ""
         )
         if not self.device_attribute:
-            LOG.warning(f"Received invalid reading for {self.device_id}: {kwargs}")
+            LOG.warning(
+                f"Received invalid reading for {self.device_id}: {kwargs}")
 
     def __repr__(self) -> str:
         return f"<Reading {self.device_attribute.attr} {self.value}{self.unit_of_measurement}>"
diff --git a/pyhilo/device/climate.py b/pyhilo/device/climate.py
@@ -1,4 +1,4 @@
-"""Climate object """
+"""Climate object"""
 
 from typing import Union, cast
 
diff --git a/pyhilo/device/light.py b/pyhilo/device/light.py
@@ -1,4 +1,4 @@
-"""Light object """
+"""Light object"""
 
 from typing import Union
 
diff --git a/pyhilo/device/sensor.py b/pyhilo/device/sensor.py
@@ -1,4 +1,4 @@
-"""Climate object """
+"""Climate object"""
 
 from typing import Union
 
diff --git a/pyhilo/device/switch.py b/pyhilo/device/switch.py
@@ -1,4 +1,4 @@
-"""Switch object """
+"""Switch object"""
 
 from typing import Union
 
diff --git a/pyhilo/exceptions.py b/pyhilo/exceptions.py
@@ -1,62 +1,43 @@
 """Define package errors."""
+
 from __future__ import annotations
 
 
 class HiloError(Exception):
     """A base error."""
 
-    pass
-
 
 class EndpointUnavailableError(HiloError):
     """An error related to accessing an endpoint that isn't available in the plan."""
 
-    pass
-
 
 class InvalidCredentialsError(HiloError):
     """An error related to invalid credentials."""
 
-    pass
-
 
 class RequestError(HiloError):
     """An error related to invalid requests."""
 
-    pass
-
 
 class WebsocketError(HiloError):
     """An error related to generic websocket errors."""
 
-    pass
-
 
 class CannotConnectError(WebsocketError):
     """Define a error when the websocket can't be connected to."""
 
-    pass
-
 
 class ConnectionClosedError(WebsocketError):
     """Define a error when the websocket closes unexpectedly."""
 
-    pass
-
 
 class ConnectionFailedError(WebsocketError):
     """Define a error when the websocket connection fails."""
 
-    pass
-
 
 class InvalidMessageError(WebsocketError):
     """Define a error related to an invalid message from the websocket server."""
 
-    pass
-
 
 class NotConnectedError(WebsocketError):
     """Define a error when the websocket isn't properly connected to."""
-
-    pass
diff --git a/pyhilo/oauth2.py b/pyhilo/oauth2.py
@@ -1,4 +1,5 @@
 """Custom OAuth2 implementation."""
+
 import base64
 import hashlib
 import os
diff --git a/pyhilo/util/state.py b/pyhilo/util/state.py
@@ -83,7 +83,7 @@ async def get_state(state_yaml: str) -> StateDict:
     """
     if not isfile(state_yaml):
         return __get_defaults__(StateDict)  # type: ignore
-    async with aiofiles.open(state_yaml, mode="r") as yaml_file:
+    async with aiofiles.open(state_yaml) as yaml_file:
         LOG.debug("Loading state from yaml")
         content = await yaml_file.read()
         state_yaml_payload: StateDict = yaml.safe_load(content)
diff --git a/pyproject.toml b/pyproject.toml
@@ -47,14 +47,13 @@ Sphinx = "^7.1.2"
 aresponses = "^3.0.0"
 codespell = "2.4.1"
 covdefaults = "2.3.0"
-coverage = {version = "7.6.12", extras = ["toml"]}
 mypy = "1.15.0"
 asynctest = "^0.13.0"
 pre-commit = "^4.0.0"
 pre-commit-hooks = "5.0.0"
 pylint = "3.3.4"
 pytest = "^8.0.0"
-pytest-aiohttp = "^1.0.4"
+pytest-asyncio = "0.25.3"
 pytest-cov = "^6.0.0"
 ruff = "0.9.6"
 safety = "3.3.0"
@@ -63,14 +62,6 @@ yamllint = "1.35.1"
 sphinx-rtd-theme = "^3.0.0"
 types-pytz = "^2025.1.0"
 
-[tool.coverage.run]
-plugins = ["covdefaults"]
-source = ["hilo"]
-
-[tool.coverage.report]
-fail_under = 25
-show_missing = true
-
 [tool.mypy]
 # Specify the target platform details in config, so your developers are
 # free to run mypy on Windows, Linux, or macOS and get consistent
@@ -102,6 +93,11 @@ warn_return_any = true
 warn_unused_configs = true
 warn_unused_ignores = true
 
+[tool.pylint.MASTER]
+ignore = [
+  "tests",
+]
+
 [tool.pylint.BASIC]
 expected-line-ending-format = "LF"
 
@@ -123,8 +119,8 @@ max-line-length = 88
 max-attributes = 20
 
 [tool.pytest.ini_options]
-addopts = "--cov"
 asyncio_mode = "auto"
+asyncio_default_fixture_loop_scope = "function"
 
 [tool.ruff.lint]
 ignore = [
@@ -150,6 +146,9 @@ known-first-party = ["hilo"]
 [tool.ruff.lint.mccabe]
 max-complexity = 25
 
+[tool.codespell]
+ignore-words-list = "hass,chambre"
+
 [build-system]
 requires = ["setuptools >= 35.0.2", "wheel >= 0.29.0", "poetry-core>=1.2.0"]
 build-backend = "poetry.core.masonry.api"
diff --git a/test-requirements.txt b/test-requirements.txt
@@ -1 +1 @@
-types-python-dateutil>=2.3.3
+types-python-dateutil>=2.3.3
diff --git a/tests/__init__.py b/tests/__init__.py
diff --git a/tests/device/test_device_reading.py b/tests/device/test_device_reading.py
diff --git a/tests/ruff.toml b/tests/ruff.toml

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+---`
`1`	`2`	`version: 2`
`2`	`3`	`updates:`
`3`	`4`	`- package-ecosystem: github-actions`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+---`
`1`	`2`	`categories:`
`2`	`3`	`- title: ":boom: Breaking Changes"`
`3`	`4`	`label: "breaking"`
Original file line number	Diff line number	Diff line change
`@@ -22,4 +22,4 @@`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`	`]`
`25`		`- }`
	`25`	`+ }`
Original file line number	Diff line number	Diff line change
`@@ -976,4 +976,4 @@`
`976`	`976`	`]`
`977`	`977`	`}`
`978`	`978`	`]`
`979`		`- }`
	`979`	`+ }`
Original file line number	Diff line number	Diff line change
`@@ -170,4 +170,4 @@`
`170`	`170`	`}`
`171`	`171`	`}`
`172`	`172`	`]`
`173`		`- }`
	`173`	`+ }`