[Toggle-group] Component concerns #951
-
A few concerns with this component:
The main issue I see with this component is its concept since I can't figure out what use cases we are trying to cover with it. Is it an Actions Group, a Button Group, a Toggle Button Group, or a Content Switcher...? I think we need to define this a bit more this component. To allow the user to select more than one option (and been a few options, not more than 1 or 2) we may need another kind of component:
Adobe Spectrum approach:
Other approaches:
|
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
In my opinion, the use cases currently covered by the toggle group can be effectively handled by other components in our design system, such as the radio group or the switch, depending on the context. Additionally, since selections made with the toggle group are not submitted by default in a form, we should rethink this component to add more value and clearly differentiate it from others that serve a similar purpose. After analyzing multiple UIs from other products, I agree with Iván that this component currently sits somewhere between what we already have and something closer to Spectrum’s Action Group. |
Beta Was this translation helpful? Give feedback.
-
New toggle group component with all the feedback applied!!! https://developer.dxc.com/halstack/next/components/toggle-group/ |
Beta Was this translation helpful? Give feedback.
In my opinion, the use cases currently covered by the toggle group can be effectively handled by other components in our design system, such as the radio group or the switch, depending on the context. Additionally, since selections made with the toggle group are not submitted by default in a form, we should rethink this component to add more value and clearly differentiate it from others that serve a similar purpose.
After analyzing multiple UIs from other products, I agree with Iván that this component currently sits somewhere between what we already have and something closer to Spectrum’s Action Group.
We could address this by redefining the component, ensuring it adds meaningful value …