-
Notifications
You must be signed in to change notification settings - Fork 202
move files into embedded templates #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djeebus
wants to merge
14
commits into
envd-nice-again
Choose a base branch
from
use-templates-for-files-layer
base: envd-nice-again
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes it easier to read the individual files and for linters to parse them.
packages/orchestrator/internal/template/build/core/rootfs/files/inittab.tpl
Outdated
Show resolved
Hide resolved
packages/orchestrator/internal/template/build/core/rootfs/rootfs.go
Outdated
Show resolved
Hide resolved
packages/orchestrator/internal/template/build/core/rootfs/rootfs.go
Outdated
Show resolved
Hide resolved
packages/orchestrator/internal/template/build/core/rootfs/rootfs.go
Outdated
Show resolved
Hide resolved
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
dobrac
approved these changes
Dec 1, 2025
Contributor
dobrac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, but LGTM 🚀
packages/orchestrator/internal/template/build/core/rootfs/rootfs.go
Outdated
Show resolved
Hide resolved
this simplified a lot of code
packages/orchestrator/internal/template/build/core/rootfs/rootfs.go
Outdated
Show resolved
Hide resolved
packages/orchestrator/internal/template/build/core/rootfs/rootfs.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes it easier to read the individual files and for linters to parse them.
Note
Embeds rootfs system files as templates and refactors build/provisioning to use them, adds tests, fixes OCI layer paths, and tweaks benchmark logging.
embed.FSand render using Go templates (files/*.tpl).templateModel(with.WriteFile,MemoryLimit) andaddTemplatedFilesToMapto generate file map.ProvisionExitPrefix,ProvisionLogPrefix, paths) and replace inline strings.CreateExt4Filesystem/additionalOCILayerssignatures and usage.rootfs.ProvisionScriptFile./inlayer_file.go.rootfs/rootfs_test.goto validate generated files in the OCI layer.zapdev logger with whitespace-stripping core inbenchmark_test.go.Written by Cursor Bugbot for commit bc0adf7. This will update automatically on new commits. Configure here.