Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Configuration xml contains questionable example #3238

Open
duncdrum opened this issue Jan 30, 2020 · 2 comments
Open

[BUG] Configuration xml contains questionable example #3238

duncdrum opened this issue Jan 30, 2020 · 2 comments
Labels
enhancement new features, suggestions, etc. needs documentation Signals issues or PRs that will require an update to the documentation repo
Milestone
eXist-7.0.1

Comments

@duncdrum
Copy link
Contributor

duncdrum commented Jan 30, 2020 •
edited
Loading

Describe the bug
This line uses output-dir to specify backup location, the docs/configutation.xml uses dir while the docs/backup.xml uses output which i think is the correct one.

This is confusing, even if all three names work (do they?), we should be consistent within the same file between here and the docs.

Also the docs claim exports to be relative to "exists main data dir" aka exist/data the inline says: (WEB-INF/data) which one is it?

Expected behavior
Consistent instructions for how to name things. 正名 

  • eXist-db version: [develop HEAD]
  • docs 5.0.1

Additional context
@triage-new-issues triage-new-issues bot added the triage issue needs to be investigated label Jan 30, 2020
@duncdrum
Copy link
Contributor Author

Its not WEB-INF/data

@duncdrum duncdrum mentioned this issue Jan 30, 2020
Closed
@adamretter
Copy link
Contributor

This line uses output-dir to specify backup location, the docs/configutation.xml uses dir while the docs/backup.xml uses output which i think is the correct one.

Actually, those are 3 different parameters for 3 different tasks:

  1. output-dir is used for DataBackup
  2. dir is used for BackupSystemTask
  3. output is used for ConsistencyCheckTask

@adamretter adamretter added this to the eXist-5.2.1 milestone Apr 6, 2020
@line-o line-o added the enhancement new features, suggestions, etc. label Apr 8, 2020
@triage-new-issues triage-new-issues bot removed the triage issue needs to be investigated label Apr 8, 2020
@line-o line-o added the needs documentation Signals issues or PRs that will require an update to the documentation repo label Apr 8, 2020
@adamretter adamretter modified the milestones: eXist-5.3.1, eXist-5.3.2 Dec 16, 2021
@adamretter adamretter modified the milestones: eXist-5.3.2, eXist-6.0.2 Feb 14, 2022
@adamretter adamretter modified the milestones: eXist-6.0.2, eXist-6.1.1 Jan 15, 2023
@adamretter adamretter modified the milestones: eXist-6.1.1, eXist-7.0.1 Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement new features, suggestions, etc. needs documentation Signals issues or PRs that will require an update to the documentation repo
Projects
None yet
Milestone
eXist-7.0.1
Development

No branches or pull requests
3 participants
@line-o @adamretter @duncdrum