Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cicd] Build with Java16 #3840

Closed
wants to merge 2 commits into from

Conversation

dizzzz
Copy link
Member

@dizzzz dizzzz commented Apr 27, 2021

Lets check the build results;
Java15 is EOL and unstable for eXist-db; v16 is more logical to use.

@dizzzz dizzzz requested a review from duncdrum April 27, 2021 11:29
@dizzzz dizzzz marked this pull request as draft April 27, 2021 17:44
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci changes are good, these failures we ll have to see

@duncdrum
Copy link
Contributor

@dizzzz can you allow J16 to fail using this syntax for now, also lets build the javadocs so at least we know whats coming up (also allow fail). This would then be good to merge, imv.

@joewiz joewiz linked an issue May 17, 2021 that may be closed by this pull request
@joewiz
Copy link
Member

joewiz commented May 17, 2021

From today's Community Call notes:

@duncdrum: suggest to pull-in java16 pr, as 15 is EOL. accept build issues (as Java15) and work on it for fixes

@duncdrum I assume this means you are ok merging this as is, without the syntax change that you suggested above and despite the CI failures?

If so, could you please "approve" the PR?

@duncdrum
Copy link
Contributor

@joewiz this is still a draft PR, as discussed I m happy to merge, once we allow the build to fail, which will also help our larger CI issues

@dizzzz dizzzz marked this pull request as ready for review May 18, 2021 11:37
@dizzzz
Copy link
Member Author

dizzzz commented May 18, 2021

todo:

  • allow failing

…ch_to_java16

* 'develop' of github.com:eXist-db/exist: (50 commits)
  [bugfix] throw error in `repo:get-resource` if file does not exist
  [bugfix] Attempt to get Coveralls plugin working, see: trautonen/coveralls-maven-plugin#136
  [refactor] Only log code-coverage against develop branch
  [bugfix] Specify the COVERALLS_TOKEN in the correct way for CI
  [doc] Add a note about explicitly closing connections
  [bugfix] Fix integration tests
  [feature] Add sql:close-connection#1 function to allow a user to explicitly close a SQL connection earlier to save resources
  [refactor] Cleanup context map accessor code
  Bump jetty.version from 9.4.40.v20210413 to 9.4.41.v20210516
  Bump bifurcan from 0.2.0-alpha4 to 0.2.0-alpha6
  [bugfix] Replace expired SSL certificate
  [refactor] Switch to standardised PKCS12 keystore type
  [security] Disable insecure SSL/TLS options
  [refactor] Indent output
  Bump jmh.version from 1.30 to 1.31
  [bugfix] Fix dependency issue
  Fix dependencies
  [feature] Update to Commons Daemon 1.2.4 Closes eXist-db#3861
  [feature] Enforce Compatible Java check at all start-up points of eXist-db
  [refactor] Remove dead code
  ...
@dizzzz
Copy link
Member Author

dizzzz commented May 24, 2021

@duncdrum I have no idea how to implement your suggestion, this is way beyond by current understanding. Please could you make the required changes in this PR ?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@duncdrum
Copy link
Contributor

@dizzzz no worries i ll add the necessary config changes and cherry-pick your commits

@dizzzz dizzzz marked this pull request as draft June 3, 2021 19:33
@duncdrum
Copy link
Contributor

@dizzzz this was superseded in the interim, if there is anything i overlooked please reopen

@duncdrum duncdrum closed this Jun 24, 2021
@dizzzz dizzzz deleted the feature/switch_to_java16 branch June 24, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Make eXist-db compatible with Java16
3 participants