-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation issue #14
Comments
playwright is marked as a peer dependency so will not necessarily install when you install cursor-tools IMO playwright is better installed globally than per package because it pulls in chromium and stuff. To fix I believe you should I am not an expert on this so if there's some expert guidance on the best way to add a playwright dependency I would love to see it |
I faced some issues with playwright globally installed too. Personally, I'm installing and uninstalling cursor-tools to the project as dev dependency, and not pushing to my project's repos. What if we move playwright as a dependency? Since it is required on install? |
@atreib thanks for the report, it’s useful for thinking about how this should change. For you can you try removing cursor-tools from your project package.json? And installing the latest cursor@alpha globally with: npm install -g cursor-tools@alpha And see if that works more smoothly for you? |
it did installed correctly and, after I ran
and it works! But when I try to use it inside of Composer, it generates the commands like this:
Which fails due to playwright not found. I can see in the IMO, we can:
I can do a PR with both pretty quickly, if you agree 🙂 |
I personally dropped the without install and it works better for me. |
@atreib it seems like local install works better for some people and global better for others. And for others particulary people who aren’t familiar with node, the “ephemeral” method where everything runs with npx is preferred) I think what we need to do is figure out which installation people have (ephemeral, local or global) and set the .cursorrules prompts accordingly. In the meantime you can as a workaround add “cursor tools is installed <globaly|locally|ephemeray> always run it using <just cursor-tools | npm exec | npx>” (delete as appropriate) to the top of your cursorrules before the cursor-tools section |
Adding fn a warning if playwright is not detected is definitely a good move. On dropping the without instructions bit - if you think it’s a good idea put it in a PR so we know exactly what the change is then we can test and discuss it with a concrete example. |
install complaining on Node version on playwright
seems to be a deeper issue with cursor-tools and its ESM imports. Let's try a complete cleanup and reinstall:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'playwright' imported from /Users/nicholas/.npm/_npx/99e823aa0445d96b/node_modules/cursor-tools/dist/index.mjs at packageResolve (node:internal/modules/esm/resolve:854:9) at moduleResolve (node:internal/modules/esm/resolve:927:18) at defaultResolve (node:internal/modules/esm/resolve:1169:11) at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:542:12) at ModuleLoader.resolve (node:internal/modules/esm/loader:510:25) at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:239:38) at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:96:40) at link (node:internal/modules/esm/module_job:95:36) { code: 'ERR_MODULE_NOT_FOUND' }
eventually installed (The older version (0.1.0) worked.) but complained along the way: node: v20.18.2
The text was updated successfully, but these errors were encountered: