Skip to content

Commit fe68c32

Browse files
Update logo links in README (#166)
* Update logo links in README * Update linting, formatting, and testing scripts - Added `--fix` option to notebook formatting check - Introduced a new script for running Jupyter notebooks - Included functional tests in the test runner script * Fix typo in CI workflow for notebook checks
1 parent 7363785 commit fe68c32

File tree

5 files changed

+15
-6
lines changed

5 files changed

+15
-6
lines changed

.github/workflows/ci-testing.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# - Download the Python package from the previous job
1515
# - Install the downloaded Python package
1616
# - Test the code base
17-
# - Check if Jupiter Notebooks run without errors
17+
# - Check if Jupyter Notebooks run without errors
1818

1919
name: Test code, notebooks and package
2020

@@ -251,7 +251,7 @@ jobs:
251251
run: >
252252
pytest tests/ --color=yes -n auto
253253
254-
- name: Check if Jupiter Notebooks run without errors
254+
- name: Check if Jupyter Notebooks run without errors
255255
shell: bash
256256
run: >
257257
pytest --nbmake examples/ --ignore-glob='examples/*emcee*'

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<p align='left'>
22
<picture>
33
<!-- light mode logo -->
4-
<source media='(prefers-color-scheme: light)' srcset='https://raw.githubusercontent.com/EasyScience/EasyDiffraction/master/resources/logo/EasyDiffractionLib-logo_lightmode.svg'>
4+
<source media='(prefers-color-scheme: light)' srcset='https://raw.githubusercontent.com/EasyScience/BrandingResources/refs/heads/master/EasyDiffraction/logos/ed-logo_light.svg'>
55
<!-- dark mode logo -->
6-
<source media='(prefers-color-scheme: dark)' srcset='https://raw.githubusercontent.com/EasyScience/EasyDiffraction/master/resources/logo/EasyDiffractionLib-logo_darkmode.svg'>
6+
<source media='(prefers-color-scheme: dark)' srcset='https://raw.githubusercontent.com/EasyScience/BrandingResources/refs/heads/master/EasyDiffraction/logos/ed-logo_dark.svg'>
77
<!-- default logo == light mode logo -->
8-
<img src='https://raw.githubusercontent.com/EasyScience/EasyDiffraction/master/resources/logo/EasyDiffractionLib-logo_lightmode.svg' alt='EasyCrystallography'>
8+
<img src='https://raw.githubusercontent.com/EasyScience/BrandingResources/refs/heads/master/EasyDiffraction/logos/ed-logo_light.svg' alt='EasyDiffraction'>
99
</picture>
1010
</p>
1111

tools/linting_and_formatting.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ echo "\033[0;33m:::::: Check and fix code formatting\033[0m"
55
ruff format .
66

77
echo "\033[0;33m:::::: Check and fix notebook formatting\033[0m"
8-
nbqa ruff examples/
8+
nbqa ruff examples/ --fix
99

1010
echo "\033[0;33m:::::: Check and fix non-code formatting\033[0m"
1111
npx prettier . --write --config=prettierrc.toml

tools/run_notebooks.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
echo "\033[0;33m:::::: Add src to pythonpath\033[0m"
2+
export PYTHONPATH="${PWD}/src:${PYTHONPATH}"
3+
echo "PYTHONPATH: ${PYTHONPATH}"
4+
5+
echo "\033[0;33m:::::: Run Jupyter notebooks\033[0m"
6+
pytest --nbmake examples/ --ignore-glob='examples/*emcee*' --nbmake-timeout=300 --color=yes -n=auto

tools/run_tests.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,8 @@ echo "PYTHONPATH: ${PYTHONPATH}"
55
echo "\033[0;33m:::::: Run unit tests\033[0m"
66
pytest tests/unit_tests/ --color=yes --disable-warnings
77

8+
echo "\033[0;33m:::::: Run functional tests\033[0m"
9+
pytest tests/functional_tests/ --color=yes --disable-warnings
10+
811
echo "\033[0;33m:::::: Run integration tests\033[0m"
912
pytest tests/integration_tests/ --color=yes --disable-warnings

0 commit comments

Comments
 (0)