Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File writer callbacks do not match spec. #23

Open
ncbray opened this issue Jun 13, 2013 · 1 comment
Open

File writer callbacks do not match spec. #23

ncbray opened this issue Jun 13, 2013 · 1 comment

Comments

@ncbray
Copy link

ncbray commented Jun 13, 2013

Currently the FileWriter calls onwriteend on success, and onerror on failure.

It should call onwrite on success, onerror on failiure, and then onwriteend in both cases.

@thosaka
Copy link

thosaka commented Sep 9, 2013

Hi ncbray and Eric, I tested this library with simple FileSystem Writer API sample and most of functions were just working great on both FireFox and google chrome. but i also found both onwritestart and onwriteend should return ProgressEvent which contain fileWriter as target. below is the one chrome returned when it fire onwriteend callback.

fileWriter.onwriteend = function(e) { ... }

e: ProgressEvent
    target: FileWriter
    type: "writeend"
    lengthComputable: true
    loaded: 50
    total: 50
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants