When converting to Fibex keep the signal instance start position as in dbc file #832
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting to fibex, keep signal start position as is in dbc file
SabrineBH
changed the title
SabrineBH
changed the title
|
@ebroecker Can you please check this PR and merge it ? |
|
Hi @SabrineBH your PR makes a lot of tests fail, could you have another look on it? |
fix unit test
…ttps://github.com/SabrineBH/canmatrix into fbx_keep_the_signal_start_position_as_in_dbc_file
|
Unit test updated |
|
Hi @SabrineBH I think this PR tries to fix the issue in the wrong place. With not looking to deep in the fibex for now, I could imagine the issue could be fixed here: canmatrix/src/canmatrix/formats/fibex.py Line 84 in fc2cf58 by changing from str(signal.start_bit)to str(signal.get_startbit(bit_numbering=1)Maybe you can double-check my approach as I am not totally sure how the fibex should look like... |
|
@ebroecker suggestion took into consideration, can you please check the PR. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting to fibex, keep signal start position as is in dbc file