chore(api): rector to php80

I know we started with php 8 with this version of the backend,
but it seems we did not write php8 code.
Disable ClosureToArrowFunctionRector for now because too much would change,
and one can argue that it's a choice to use a closure instead
of an arrow function.

Author: BacLuc

api/config/bootstrap.php

@@ -19,5 +19,5 @@
 
 $_SERVER += $_ENV;
 $_SERVER['APP_ENV'] = $_ENV['APP_ENV'] = ($_SERVER['APP_ENV'] ?? $_ENV['APP_ENV'] ?? null) ?: 'dev';
-$_SERVER['APP_DEBUG'] = $_SERVER['APP_DEBUG'] ?? $_ENV['APP_DEBUG'] ?? 'prod' !== $_SERVER['APP_ENV'];
+$_SERVER['APP_DEBUG'] ??= $_ENV['APP_DEBUG'] ?? 'prod' !== $_SERVER['APP_ENV'];
 $_SERVER['APP_DEBUG'] = $_ENV['APP_DEBUG'] = (int) $_SERVER['APP_DEBUG'] || filter_var($_SERVER['APP_DEBUG'], FILTER_VALIDATE_BOOLEAN) ? '1' : '0';

api/rector.php

@@ -13,6 +13,7 @@
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\If_\RemoveDeadInstanceOfRector;
 use Rector\Doctrine\Bundle230\Rector\Class_\AddAnnotationToRepositoryRector;
+use Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
 use Rector\PHPUnit\CodeQuality\Rector\ClassMethod\AddInstanceofAssertForNullableInstanceRector;
 use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector;
@@ -34,6 +35,7 @@
     ->withComposerBased(doctrine: true, phpunit: true, symfony: true)
     ->withPreparedSets(deadCode: true, codeQuality: true, privatization: true, rectorPreset: true, phpunitCodeQuality: true, symfonyCodeQuality: true)
     ->withAttributesSets(all: true)
+    ->withPhpSets(php80: true)
     ->withConfiguredRule(RenameFunctionRector::class, [
         'implode' => 'join',
         'join' => 'join',
@@ -42,6 +44,7 @@
         AddAnnotationToRepositoryRector::class,
         AddInstanceofAssertForNullableInstanceRector::class,
         AssertEmptyNullableObjectToAssertInstanceofRector::class,
+        ClosureToArrowFunctionRector::class,
         CombineIfRector::class,
         ConstraintOptionsToNamedArgumentsRector::class,
         DeclareStrictTypesRector::class,

api/src/DTO/Invitation.php

@@ -62,47 +62,39 @@ class Invitation {
         'swagger_definition_name' => 'read',
     ];
 
-    #[ApiProperty(readable: false, writable: false, identifier: true, example: 'myInviteKey')]
-    public string $inviteKey;
-
-    /**
-     * The id of the camp for which this invitation is valid. This is useful for
-     * redirecting the user to the correct place after they accept.
-     */
-    #[ApiProperty(writable: false, example: '1a2b3c4d')]
-    #[Groups('read')]
-    public string $campId;
-
-    /**
-     * The full title of the camp for which this invitation is valid. This should help
-     * the user to decide whether to accept or reject the invitation.
-     */
-    #[ApiProperty(writable: false, example: 'Abteilungs-Sommerlager 2022')]
-    #[Groups('read')]
-    public string $campTitle;
-
-    /**
-     * The display name of the user that is invited. May be null in case the user does
-     * not already have an account.
-     */
-    #[ApiProperty(writable: false, example: 'Robert Baden-Powell')]
-    #[Groups('read')]
-    public ?string $userDisplayName;
-
-    /**
-     * Indicates whether the logged in user is already collaborating in the camp, and
-     * can therefore not accept the invitation.
-     */
-    #[ApiProperty(writable: false, example: false)]
-    #[Groups('read')]
-    #[Assert\IsFalse(message: 'This user is already associated with the camp.', groups: ['accept'])]
-    public ?bool $userAlreadyInCamp;
-
-    public function __construct(string $inviteKey, string $campId, string $campTitle, ?string $userDisplayName, ?bool $userAlreadyInCamp) {
-        $this->inviteKey = $inviteKey;
-        $this->campId = $campId;
-        $this->campTitle = $campTitle;
-        $this->userDisplayName = $userDisplayName;
-        $this->userAlreadyInCamp = $userAlreadyInCamp;
+    public function __construct(
+        #[ApiProperty(readable: false, writable: false, identifier: true, example: 'myInviteKey')]
+        public string $inviteKey,
+        /**
+         * The id of the camp for which this invitation is valid. This is useful for
+         * redirecting the user to the correct place after they accept.
+         */
+        #[ApiProperty(writable: false, example: '1a2b3c4d')]
+        #[Groups('read')]
+        public string $campId,
+        /**
+         * The full title of the camp for which this invitation is valid. This should help
+         * the user to decide whether to accept or reject the invitation.
+         */
+        #[ApiProperty(writable: false, example: 'Abteilungs-Sommerlager 2022')]
+        #[Groups('read')]
+        public string $campTitle,
+        /**
+         * The display name of the user that is invited. May be null in case the user does
+         * not already have an account.
+         */
+        #[ApiProperty(writable: false, example: 'Robert Baden-Powell')]
+        #[Groups('read')]
+        public ?string $userDisplayName,
+        /**
+         * Indicates whether the logged in user is already collaborating in the camp, and
+         * can therefore not accept the invitation.
+         */
+        #[ApiProperty(writable: false, example: false)]
+        #[Groups('read')]
+        #[Assert\IsFalse(message: 'This user is already associated with the camp.', groups: ['accept'])]
+        public ?bool $userAlreadyInCamp
+    )
+    {
     }
 }

api/src/DTO/PersonalInvitation.php

@@ -57,29 +57,25 @@ class PersonalInvitation {
         'swagger_definition_name' => 'read',
     ];
 
-    #[ApiProperty(readable: true, writable: false, identifier: true, example: '1a2b3c4d')]
-    #[Groups('read')]
-    public string $id;
-
-    /**
-     * The id of the camp for which this invitation is valid. This is useful for
-     * redirecting the user to the correct place after they accept.
-     */
-    #[ApiProperty(writable: false, example: '1a2b3c4d')]
-    #[Groups('read')]
-    public string $campId;
-
-    /**
-     * The full title of the camp for which this invitation is valid. This should help
-     * the user to decide whether to accept or reject the invitation.
-     */
-    #[ApiProperty(writable: false, example: 'Abteilungs-Sommerlager 2022')]
-    #[Groups('read')]
-    public string $campTitle;
-
-    public function __construct(string $id, string $campId, string $campTitle) {
-        $this->id = $id;
-        $this->campId = $campId;
-        $this->campTitle = $campTitle;
+    public function __construct(
+        #[ApiProperty(readable: true, writable: false, identifier: true, example: '1a2b3c4d')]
+        #[Groups('read')]
+        public string $id,
+        /**
+         * The id of the camp for which this invitation is valid. This is useful for
+         * redirecting the user to the correct place after they accept.
+         */
+        #[ApiProperty(writable: false, example: '1a2b3c4d')]
+        #[Groups('read')]
+        public string $campId,
+        /**
+         * The full title of the camp for which this invitation is valid. This should help
+         * the user to decide whether to accept or reject the invitation.
+         */
+        #[ApiProperty(writable: false, example: 'Abteilungs-Sommerlager 2022')]
+        #[Groups('read')]
+        public string $campTitle
+    )
+    {
     }
 }

api/src/Doctrine/Filter/ExpressionDateTimeFilter.php

@@ -134,7 +134,7 @@ protected function addWhere(
     ) {
         try {
             $value = new \DateTime($value);
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             // Silently ignore this filter if it can not be transformed to a \DateTime
             $this->logger->notice('Invalid filter ignored', [
                 'exception' => new InvalidArgumentException(sprintf('The field "%s" has a wrong date format. Use one accepted by the \DateTime constructor', $field)),

api/src/Doctrine/FilterByCurrentUserExtension.php

@@ -13,12 +13,8 @@
 use Symfony\Bundle\SecurityBundle\Security;
 
 final class FilterByCurrentUserExtension implements QueryCollectionExtensionInterface, QueryItemExtensionInterface {
-    private Security $security;
-    private EntityManagerInterface $entityManager;
-
-    public function __construct(Security $security, EntityManagerInterface $entityManager) {
-        $this->security = $security;
-        $this->entityManager = $entityManager;
+    public function __construct(private Security $security, private EntityManagerInterface $entityManager)
+    {
     }
 
     public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, ?string $resourceClass = null, ?Operation $operation = null, array $context = []): void {

api/src/Doctrine/Orm/Extension/FilterEagerLoadingsExtension.php

@@ -62,7 +62,7 @@ private function buildAliasMap(EntityManagerInterface $em, ClassMetadata $classM
 
         foreach ($joins as $join) {
             // @var Join $join
-            list($fromAlias, $fromProperty) = explode('.', $join->getJoin(), 2);
+            [$fromAlias, $fromProperty] = explode('.', $join->getJoin(), 2);
             $toAlias = $join->getAlias();
 
             $fromClassMetadata = $aliasMap[$fromAlias][0];

api/src/Entity/Activity.php

@@ -144,7 +144,7 @@ class Activity extends BaseEntity implements BelongsToCampInterface {
      */
     #[ApiProperty(example: '/activities/1a2b3c4d')]
     #[Groups(['create'])]
-    public ?Activity $copyActivitySource;
+    public ?Activity $copyActivitySource = null;
 
     /**
      * The current assigned ProgressLabel.

api/src/Entity/Camp.php

@@ -246,7 +246,7 @@ class Camp extends BaseEntity implements BelongsToCampInterface, CopyFromPrototy
     #[ApiProperty(example: 'SoLa 2022')]
     #[Groups(['read', 'write'])]
     #[ORM\Column(type: 'text', nullable: true)]
-    public ?string $shortTitle;
+    public ?string $shortTitle = null;
 
     /**
      * The full title of the camp. Used for identifying the camp in lists of camps, so

api/src/Entity/Category.php

@@ -140,7 +140,7 @@ class Category extends BaseEntity implements BelongsToCampInterface, CopyFromPro
      */
     #[ApiProperty(example: '/categories/1a2b3c4d')]
     #[Groups(['create'])]
-    public Activity|Category|null $copyCategorySource;
+    public Activity|Category|null $copyCategorySource = null;
 
     /**
      * The id of the category that was used as a template for creating this category. Internal for now, is
@@ -257,25 +257,14 @@ public function removeActivity(Activity $activity): void {
     }
 
     public function getStyledNumber(int $num): string {
-        switch ($this->numberingStyle) {
-            case 'a':
-                return strtolower($this->getAlphaNum($num));
-
-            case 'A':
-                return strtoupper($this->getAlphaNum($num));
-
-            case 'i':
-                return strtolower($this->getRomanNum($num));
-
-            case 'I':
-                return strtoupper($this->getRomanNum($num));
-
-            case '-':
-                return '';
-
-            default:
-                return strval($num);
-        }
+        return match ($this->numberingStyle) {
+            'a' => strtolower($this->getAlphaNum($num)),
+            'A' => strtoupper($this->getAlphaNum($num)),
+            'i' => strtolower($this->getRomanNum($num)),
+            'I' => strtoupper($this->getRomanNum($num)),
+            '-' => '',
+            default => strval($num),
+        };
     }
 
     /**